From 69bcf03fc61785ba893aee2637d0a333e38b7237 Mon Sep 17 00:00:00 2001
From: Sanjana <sanju250506@gmail.com>
Date: Mon, 2 Feb 2026 23:44:58 +0530
Subject: [PATCH] Implement missing tests and cleanup TODOs in
 DependencyVisitorTest

---
 .../analyzer/asm/DependencyVisitorTest.java   | 35 ++++++++++---------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
index 7d814e70..18aab182 100644
--- a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
+++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
@@ -150,9 +150,9 @@ void testVisitSource() {
     void testVisitOuterClass() {
         // class a.b.c
         // {
-        //     class ...
-        //     {
-        //     }
+        // class ...
+        // {
+        // }
         // }
         visitor.visitOuterClass("a/b/c", null, null);
 
@@ -163,12 +163,12 @@ void testVisitOuterClass() {
     void testVisitOuterClassInMethod() {
         // class a.b.c
         // {
-        //     x.y.z x(p.q.r p)
-        //     {
-        //         class ...
-        //         {
-        //         }
-        //     }
+        // x.y.z x(p.q.r p)
+        // {
+        // class ...
+        // {
+        // }
+        // }
         // }
         visitor.visitOuterClass("a/b/c", "x", "(Lp/q/r;)Lx/y/z;");
 
@@ -204,10 +204,8 @@ void testVisitAttribute() {
 
     @Test
     void testVisitInnerClass() {
-        // TODO: ensure innerName is correct
-
-        // class a.b.c { class x.y.z { } }
-        visitor.visitInnerClass("x/y/z", "a/b/c", "z", 0);
+        // class a.b.c { class x { } }
+        visitor.visitInnerClass("a/b/c$x", "a/b/c", "x", 0);
 
         assertThat(resultCollector.getDependencies()).isEmpty();
     }
@@ -230,10 +228,13 @@ void testVisitField() {
         assertThat(resultCollector.getDependencies()).containsOnly("a.b.c");
     }
 
-    // TODO: determine actual use of default values
-    // void testVisitFieldWithValue()
-    // {
-    // }
+    @Test
+    void testVisitFieldWithValue() {
+        // a.b.c a = x.y.z.class
+        assertVisitor(visitor.visitField(0, "a", "La/b/c;", null, Type.getType("Lx/y/z;")));
+
+        assertThat(resultCollector.getDependencies()).containsOnly("a.b.c", "x.y.z");
+    }
 
     @Test
     void testVisitFieldArray() {