Skip to content

Conversation

@pdudits
Copy link

@pdudits pdudits commented Dec 6, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


The change realizes the approach I originally suggested in MBUILDCACHE-73. It is now possible to declare plugin's reconcilation property as

<plugin goal="deploy" artifactId="maven-deploy-plugin" groupId="org.apache.maven.plugins">
    <reconciles>
        <reconcile propertyName="project.version" expression="${project.version}"/>
     </reconciles>
</plugin>

Along the way I unified how the string value for reconciled expression is constructed -- they were different upon saving and restoration before.

Since this relies on new model properties an initial failing test case wasn't really possible.


Fixes #268.


public static void addProperty(
CompletedExecution execution, String propertyName, Object value, String baseDirPath, boolean tracked) {
CompletedExecution execution, String propertyName, Object value, Path baseDirPath, boolean tracked) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Keep the old method as a delegate to the new method and deprecate it with reference to use this method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done that, because technically it is true, however all usages all the method have been replaced. Who are potential users of the old method?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done that, because technically it is true, however all usages all the method have been replaced. Who are potential users of the old method?

https://www.hyrumslaw.com/ 🙈

Co-authored-by: Erik Meuwese <Erik.Meuwese@topicus.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MBUILDCACHE-73] Add project version as additional property for reconcilation

3 participants