-
Notifications
You must be signed in to change notification settings - Fork 59
[MBUILDCACHE-73] Allow arbitrary expressions as additional reconcilation properties #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| public static void addProperty( | ||
| CompletedExecution execution, String propertyName, Object value, String baseDirPath, boolean tracked) { | ||
| CompletedExecution execution, String propertyName, Object value, Path baseDirPath, boolean tracked) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. Keep the old method as a delegate to the new method and deprecate it with reference to use this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done that, because technically it is true, however all usages all the method have been replaced. Who are potential users of the old method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done that, because technically it is true, however all usages all the method have been replaced. Who are potential users of the old method?
src/test/projects/reconcile-expressions/.mvn/maven-build-cache-config.xml
Outdated
Show resolved
Hide resolved
src/test/projects/reconcile-expressions/src/main/java/org/apache/maven/buildcache/Test1.java
Outdated
Show resolved
Hide resolved
src/test/projects/reconcile-expressions/src/main/resources/resources.properties
Show resolved
Hide resolved
Co-authored-by: Erik Meuwese <Erik.Meuwese@topicus.nl>
9ef4dce to
e95fc97
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
The change realizes the approach I originally suggested in MBUILDCACHE-73. It is now possible to declare plugin's reconcilation property as
Along the way I unified how the string value for reconciled expression is constructed -- they were different upon saving and restoration before.
Since this relies on new model properties an initial failing test case wasn't really possible.
Fixes #268.