Prevent a fault in ODBCAppender due to conversion to unsigned (#626)

Author: jmestwa-coder

src/main/cpp/odbcappender.cpp

@@ -176,7 +176,12 @@ void ODBCAppender::setOption(const LogString& option, const LogString& value)
 {
 	if (StringHelper::equalsIgnoreCase(option, LOG4CXX_STR("BUFFERSIZE"), LOG4CXX_STR("buffersize")))
 	{
-		setBufferSize((size_t)OptionConverter::toInt(value, 1));
+		int parsed = OptionConverter::toInt(value, 1);
+		if (parsed < 0)
+		{
+			parsed = 1;
+		}
+		setBufferSize((size_t) parsed);
 	}
 	else if (StringHelper::equalsIgnoreCase(option, LOG4CXX_STR("PASSWORD"), LOG4CXX_STR("password")))
 	{

src/test/cpp/db/odbcappendertestcase.cpp

@@ -39,6 +39,7 @@ class ODBCAppenderTestCase : public AppenderSkeletonTestCase
 		//
 		LOGUNIT_TEST(testDefaultThreshold);
 		LOGUNIT_TEST(testSetOptionThreshold);
+		LOGUNIT_TEST(testNegativeBufferSizeOption);
 //#define DataSourceName_Log4cxxTest_Is_Valid
 #ifdef DataSourceName_Log4cxxTest_Is_Valid
 		LOGUNIT_TEST(testConnectUsingDSN);
@@ -59,6 +60,13 @@ class ODBCAppenderTestCase : public AppenderSkeletonTestCase
 			LogManager::shutdown();
 		}
 
+		void testNegativeBufferSizeOption()
+		{
+			db::ODBCAppender appender;
+			appender.setOption(LOG4CXX_STR("BUFFERSIZE"), LOG4CXX_STR("-10"));
+			LOGUNIT_ASSERT_EQUAL((size_t) 1, appender.getBufferSize());
+		}
+
 // 'odbcAppenderDSN-Log4cxxTest.xml' requires the data souce name 'Log4cxxTest'
 // containing a 'ApplicationLogs' database
 // with 'UnitTestLog' table