JCR-4521: Update commons-dbcp dependency to 2.14.0 (#328) - ack oleosterhagen

Copied from #320 - thanks @oleosterhagen

Author: reschke

jackrabbit-core/pom.xml

@@ -233,9 +233,9 @@ org.apache.jackrabbit.core.version.RemoveAndAddVersionLabelXATest#testVersionLab
       <artifactId>commons-io</artifactId>
     </dependency>
     <dependency>
-      <groupId>commons-dbcp</groupId>
-      <artifactId>commons-dbcp</artifactId>
-      <version>1.4</version>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-dbcp2</artifactId>
+      <version>2.14.0</version>
     </dependency>
     <dependency>
       <groupId>javax.jcr</groupId>

jackrabbit-core/src/test/java/org/apache/jackrabbit/core/util/db/ConnectionFactoryTest.java

@@ -24,7 +24,7 @@
 
 import junit.framework.TestCase;
 
-import org.apache.commons.dbcp.BasicDataSource;
+import org.apache.commons.dbcp2.BasicDataSource;
 import org.apache.derby.iapi.jdbc.EngineConnection;
 import org.apache.jackrabbit.core.config.ConfigurationException;
 import org.apache.jackrabbit.core.config.DataSourceConfig;
@@ -146,7 +146,7 @@ public void testClose() throws Exception {
     }
 
     private void assertPoolDefaults(BasicDataSource ds, String validationQuery, int maxCons) {
-        assertEquals(maxCons, ds.getMaxActive());
+        assertEquals(maxCons, ds.getMaxTotal());
         assertEquals(validationQuery, ds.getValidationQuery());
         assertTrue(ds.getDefaultAutoCommit());
         assertFalse(ds.getTestOnBorrow());

jackrabbit-data/pom.xml

@@ -86,9 +86,9 @@
 			<artifactId>commons-io</artifactId>
 		</dependency>
 		<dependency>
-			<groupId>commons-dbcp</groupId>
-			<artifactId>commons-dbcp</artifactId>
-			<version>1.4</version>
+			<groupId>org.apache.commons</groupId>
+			<artifactId>commons-dbcp2</artifactId>
+			<version>2.14.0</version>
       <optional>true</optional>
 		</dependency>
 		<dependency>

jackrabbit-data/src/main/java/org/apache/jackrabbit/core/util/db/ConnectionFactory.java

@@ -20,6 +20,7 @@
 import java.sql.Connection;
 import java.sql.Driver;
 import java.sql.SQLException;
+import java.time.Duration;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -30,9 +31,9 @@
 import javax.naming.NamingException;
 import javax.sql.DataSource;
 
-import org.apache.commons.dbcp.BasicDataSource;
-import org.apache.commons.dbcp.DelegatingConnection;
-import org.apache.commons.pool.impl.GenericObjectPool;
+import org.apache.commons.dbcp2.BasicDataSource;
+import org.apache.commons.dbcp2.DelegatingConnection;
+import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
 import org.apache.jackrabbit.core.config.DataSourceConfig;
 import org.apache.jackrabbit.core.config.DataSourceConfig.DataSourceDefinition;
 import org.apache.jackrabbit.util.Base64;
@@ -102,7 +103,7 @@ public void registerDataSources(DataSourceConfig dsc) throws RepositoryException
                     BasicDataSource bds =
                         getDriverDataSource(driverClass, def.getUrl(), def.getUser(), def.getPassword());
                     if (def.getMaxPoolSize() > 0) {
-                        bds.setMaxActive(def.getMaxPoolSize());
+                        bds.setMaxTotal(def.getMaxPoolSize());
                     }
                     if (def.getValidationQuery() != null && !"".equals(def.getValidationQuery().trim())) {
                         bds.setValidationQuery(def.getValidationQuery());
@@ -334,7 +335,7 @@ private BasicDataSource getDriverDataSource(
             if (instance != null) {
                 if (instance.jdbcCompliant()) {
                 	// JCR-3445 At the moment the PostgreSQL isn't compliant because it doesn't implement this method...                	
-                    ds.setValidationQueryTimeout(3);
+                    ds.setValidationQueryTimeout(Duration.ofSeconds(3));
                 }
             }
             ds.setDriverClassName(driverClass.getName());
@@ -346,14 +347,16 @@ private BasicDataSource getDriverDataSource(
         ds.setDefaultAutoCommit(true);
         ds.setTestOnBorrow(false);
         ds.setTestWhileIdle(true);
-        ds.setTimeBetweenEvictionRunsMillis(600000); // 10 Minutes
-        ds.setMinEvictableIdleTimeMillis(60000); // 1 Minute
-        ds.setMaxActive(-1); // unlimited
-        ds.setMaxIdle(GenericObjectPool.DEFAULT_MAX_IDLE + 10);
+        ds.setDurationBetweenEvictionRuns(Duration.ofMinutes(10));
+        ds.setMinEvictableIdle(Duration.ofMinutes(1));
+        ds.setMaxTotal(-1); // unlimited
+        ds.setMaxIdle(GenericObjectPoolConfig.DEFAULT_MAX_IDLE + 10);
         ds.setValidationQuery(guessValidationQuery(url));
         ds.setAccessToUnderlyingConnectionAllowed(true);
         ds.setPoolPreparedStatements(Boolean.valueOf(System.getProperty(SYSTEM_PROPERTY_POOL_PREPARED_STATEMENTS, "true")));
         ds.setMaxOpenPreparedStatements(-1); // unlimited
+        // this helps to discover unusable connections of a shut-down database without executing a validation query
+        ds.setCacheState(false);
         return ds;
     }