Return bounds sentinels for long date literals (#3546)

Author: kevinjqliu

pyiceberg/expressions/literals.py

@@ -329,6 +329,10 @@ def _(self, _: DoubleType) -> Literal[float]:
 
     @to.register(DateType)
     def _(self, _: DateType) -> Literal[int]:
+        if IntegerType.max < self.value:
+            return IntAboveMax()
+        elif IntegerType.min > self.value:
+            return IntBelowMin()
         return DateLiteral(self.value)
 
     @to.register(TimeType)

tests/expressions/test_expressions.py

@@ -67,6 +67,7 @@
 from pyiceberg.schema import Accessor, Schema
 from pyiceberg.typedef import Record
 from pyiceberg.types import (
+    DateType,
     DecimalType,
     DoubleType,
     FloatType,
@@ -1150,6 +1151,26 @@ def test_above_int_bounds_greater_than_or_equal(
     assert GreaterThanOrEqual("a", below_int_min).bind(int_schema) is AlwaysTrue()
 
 
+@pytest.fixture
+def date_schema() -> Schema:
+    return Schema(NestedField(field_id=1, name="a", field_type=DateType(), required=False))
+
+
+def test_above_date_bounds_equal_to(date_schema: Schema, above_int_max: Literal[int], below_int_min: Literal[int]) -> None:
+    assert EqualTo("a", above_int_max).bind(date_schema) is AlwaysFalse()
+    assert EqualTo("a", below_int_min).bind(date_schema) is AlwaysFalse()
+
+
+def test_above_date_bounds_less_than(date_schema: Schema, above_int_max: Literal[int], below_int_min: Literal[int]) -> None:
+    assert LessThan("a", above_int_max).bind(date_schema) is AlwaysTrue()
+    assert LessThan("a", below_int_min).bind(date_schema) is AlwaysFalse()
+
+
+def test_above_date_bounds_greater_than(date_schema: Schema, above_int_max: Literal[int], below_int_min: Literal[int]) -> None:
+    assert GreaterThan("a", above_int_max).bind(date_schema) is AlwaysFalse()
+    assert GreaterThan("a", below_int_min).bind(date_schema) is AlwaysTrue()
+
+
 @pytest.fixture
 def float_schema() -> Schema:
     return Schema(NestedField(field_id=1, name="a", field_type=FloatType(), required=False))

tests/expressions/test_literals.py

@@ -160,6 +160,16 @@ def test_integer_to_date_conversion() -> None:
     assert date_lit.value == date_delta
 
 
+def test_long_to_date_outside_bound() -> None:
+    big_lit = literal(IntegerType.max + 1).to(LongType())
+    above_max_lit = big_lit.to(DateType())
+    assert above_max_lit == IntAboveMax()
+
+    small_lit = literal(IntegerType.min - 1).to(LongType())
+    below_min_lit = small_lit.to(DateType())
+    assert below_min_lit == IntBelowMin()
+
+
 def test_long_to_integer_within_bound() -> None:
     lit = literal(34).to(LongType())
     int_lit = lit.to(IntegerType())