From 8480a04e04cc5c79bbd20ccc3692ea24634ec309 Mon Sep 17 00:00:00 2001 From: tanishq-chugh Date: Fri, 12 Jun 2026 14:07:46 +0530 Subject: [PATCH 1/5] [WIP] Test llap io disabled mode --- data/conf/iceberg/llap/hive-site.xml | 5 +++++ data/conf/llap/hive-site.xml | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/data/conf/iceberg/llap/hive-site.xml b/data/conf/iceberg/llap/hive-site.xml index 83802afff023..e6b23196fe0c 100644 --- a/data/conf/iceberg/llap/hive-site.xml +++ b/data/conf/iceberg/llap/hive-site.xml @@ -338,6 +338,11 @@ true + + hive.llap.io.memory.mode + none + + ipc.client.low-latency diff --git a/data/conf/llap/hive-site.xml b/data/conf/llap/hive-site.xml index 5469e73bdd7e..8df629df0d83 100644 --- a/data/conf/llap/hive-site.xml +++ b/data/conf/llap/hive-site.xml @@ -330,6 +330,11 @@ true + + hive.llap.io.memory.mode + none + + ipc.client.low-latency From ef85e8dd6b2bd24893a56069fc3656e36dc60f3b Mon Sep 17 00:00:00 2001 From: tanishq-chugh Date: Fri, 12 Jun 2026 14:13:36 +0530 Subject: [PATCH 2/5] Revert "[WIP] Test llap io disabled mode" This reverts commit 8480a04e04cc5c79bbd20ccc3692ea24634ec309. --- data/conf/iceberg/llap/hive-site.xml | 5 ----- data/conf/llap/hive-site.xml | 5 ----- 2 files changed, 10 deletions(-) diff --git a/data/conf/iceberg/llap/hive-site.xml b/data/conf/iceberg/llap/hive-site.xml index e6b23196fe0c..83802afff023 100644 --- a/data/conf/iceberg/llap/hive-site.xml +++ b/data/conf/iceberg/llap/hive-site.xml @@ -338,11 +338,6 @@ true - - hive.llap.io.memory.mode - none - - ipc.client.low-latency diff --git a/data/conf/llap/hive-site.xml b/data/conf/llap/hive-site.xml index 8df629df0d83..5469e73bdd7e 100644 --- a/data/conf/llap/hive-site.xml +++ b/data/conf/llap/hive-site.xml @@ -330,11 +330,6 @@ true - - hive.llap.io.memory.mode - none - - ipc.client.low-latency From 6d7116750c676cfceba9f1eb5c7a354394274a3a Mon Sep 17 00:00:00 2001 From: tanishq-chugh Date: Fri, 12 Jun 2026 14:14:21 +0530 Subject: [PATCH 3/5] Update in HiveConf for better coverage --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java index 662ece1c907b..999eb7360396 100644 --- a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java +++ b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java @@ -4890,7 +4890,7 @@ public static enum ConfVars { LLAP_IO_NONVECTOR_WRAPPER_ENABLED("hive.llap.io.nonvector.wrapper.enabled", true, "Whether the LLAP IO layer is enabled for non-vectorized queries that read inputs\n" + "that can be vectorized"), - LLAP_IO_MEMORY_MODE("hive.llap.io.memory.mode", "cache", + LLAP_IO_MEMORY_MODE("hive.llap.io.memory.mode", "none", new StringSet("cache", "none"), "LLAP IO memory usage; 'cache' (the default) uses data and metadata cache with a\n" + "custom off-heap allocator, 'none' doesn't use either (this mode may result in\n" + From 2137e4d609e25e48a126d9fd609d45497755b5bf Mon Sep 17 00:00:00 2001 From: tanishq-chugh Date: Sat, 13 Jun 2026 10:35:43 +0530 Subject: [PATCH 4/5] Test UTs after ORC Reader NPE fix --- .../hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java b/llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java index 75a71560b81c..34e94a08774c 100644 --- a/llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java +++ b/llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java @@ -377,7 +377,9 @@ private void performDataRead() throws IOException { // TODO: I/O threadpool could be here - one thread per stripe; for now, linear. boolean hasFileId = this.fileKey != null; OrcBatchKey stripeKey = hasFileId ? new OrcBatchKey(fileKey, -1, 0) : null; - pathCache.touch(fileKey, split.getPath().toUri().toString()); + if (pathCache != null) { + pathCache.touch(fileKey, split.getPath().toUri().toString()); + } for (int stripeIxMod = 0; stripeIxMod < stripeRgs.length; ++stripeIxMod) { if (processStop()) { return; From cea1bf671fc7e7e6287216cae2018ff14fd10eb8 Mon Sep 17 00:00:00 2001 From: tanishq-chugh Date: Sat, 13 Jun 2026 21:22:16 +0530 Subject: [PATCH 5/5] Disable delete deltas io cache --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java index 999eb7360396..7cc63913c5f6 100644 --- a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java +++ b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java @@ -5020,7 +5020,7 @@ public static enum ConfVars { "notifications are received by the daemon. Sweep phase of proactive eviction will only do the cache policy " + "cleanup in this case. This can increase cache hit ratio but might scale bad in a workload that generates " + "many proactive eviction events."), - LLAP_IO_CACHE_DELETEDELTAS("hive.llap.io.cache.deletedeltas", "all", new StringSet("none", "metadata", "all"), + LLAP_IO_CACHE_DELETEDELTAS("hive.llap.io.cache.deletedeltas", "none", new StringSet("none", "metadata", "all"), "When set to 'all' queries that use LLAP IO for execution will also access delete delta files via " + "LLAP IO layer and thus they will be fully cached. When set to 'metadata', only the tail of delete deltas " + "will be cached. If set to 'none', only the base files and insert deltas will be channeled through LLAP, " +