HBASE-29955 HMaster getting aborted due to NPE while creating snapshot for invalid table name (review comment fix)

Author: pankaj72981

hbase-server/src/test/java/org/apache/hadoop/hbase/client/SnapshotWithAclTestBase.java

@@ -330,13 +330,10 @@ public void testCreateSnapshotWithNonExistingTable() throws Exception {
     String snapshotName = tableName.getNameAsString() + "snap1";
 
     try {
-      try {
-        // Create snapshot without creating table
-        TEST_UTIL.getAdmin().snapshot(snapshotName, tableName);
-        fail("Snapshot operation should fail, table doesn't exist");
-      } catch (Exception e) {
-        assertTrue(e instanceof SnapshotCreationException);
-      }
+      // Create snapshot without creating table
+      assertThrows("Snapshot operation should fail, table doesn't exist",
+        SnapshotCreationException.class,
+        () -> TEST_UTIL.getAdmin().snapshot(snapshotName, tableName));
 
       // Create the table
       TableDescriptor htd = TableDescriptorBuilder.newBuilder(tableName).build();