grails-bom:7.0.4 rxjava versions incorrect

[jamesfredley]

Issue description

grails-bom:7.0.3: https://repo1.maven.org/maven2/org/apache/grails/grails-bom/7.0.3/grails-bom-7.0.3.pom

<dependency>
<groupId>io.reactivex</groupId>
<artifactId>rxjava</artifactId>
<version>1.3.8</version>
</dependency>
<dependency>
<groupId>io.reactivex.rxjava2</groupId>
<artifactId>rxjava</artifactId>
<version>2.2.21</version>
</dependency>
<dependency>
<groupId>io.reactivex.rxjava3</groupId>
<artifactId>rxjava</artifactId>
<version>3.1.11</version>
</dependency>

grails-bom:7.0.4: https://repo1.maven.org/maven2/org/apache/grails/grails-bom/7.0.4/grails-bom-7.0.4.pom

<dependency>
<groupId>io.reactivex</groupId>
<artifactId>rxjava</artifactId>
<version>${rxjava.version}</version>
</dependency>
<dependency>
<groupId>io.reactivex.rxjava2</groupId>
<artifactId>rxjava</artifactId>
<version>${rxjava.version}</version>
</dependency>
<dependency>
<groupId>io.reactivex.rxjava3</groupId>
<artifactId>rxjava</artifactId>
<version>${rxjava.version}</version>
</dependency>

<rxjava.version>3.1.11</rxjava.version>
<rxjava2.version>2.2.21</rxjava2.version>
<rxjava3.version>3.1.11</rxjava3.version>

[dauer]

I haven't found a solution but it fails between these two commits:

git diff 5fbc32b5cf29f01151b5d22dd37b3d7d9739caa4 4c8c911d014408807af76b5f362f8c238d4b43f0
--- a/build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/PublishPlugin.groovy
+++ b/build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/PublishPlugin.groovy
-            it.pomCustomization = lookupProperty(project, 'pomCustomization') as Closure
+            it.pomCustomization.set(project.provider { lookupProperty(project, 'pomCustomization') as Closure })

--- a/dependencies.gradle
+++ b/dependencies.gradle
-            'grails-publish-plugin.version' : '0.0.2',
+            'grails-publish-plugin.version' : '0.0.3',

...

If I delete the rxjava3.version it fallback to using the rxjava2.version but it never seems to pick the rxjava.version...

[jdaugherty]

So the only change in the publish plugin in 0.0.3 was the switch to the provider. Previously, it would have skipped the property generation, and this commit fixed the property generation because of the deferred lookup. I don't think the change is the problem here, it's likely a bug in the lookup of the property vs the map key from dependencies.gradle. It's probably been there from the start, we just missed it.

PropertyNameCalculator is where this logic is located. I'll try to find the exact issue this week and fix it. Unless someone wants to look first. All of the code in org.apache.grails.gradle.tasks.bom.* needs rewritten b/c in Gradle 9 we can't rely on resolution across projects (see ben-manes/gradle-versions-plugin#966 (comment)). Instead it will need to pull in the maven libraries themself and do the pom lookups manually.