From 4a5227401b9c025b699b66e3a12a9024f93f73c0 Mon Sep 17 00:00:00 2001
From: Adam Monsen <haircut@gmail.com>
Date: Fri, 29 May 2026 13:04:21 -0700
Subject: [PATCH] FINERACT-2637: simpler build commands
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

WIP / proposal for simpler build commands

I'd love to simplify our build commands if possible. I'm hoping we can
safely make use of the Gradle daemon to save on Java startup times and
we can let Gradle handle caching while using fewer explicit ("-x")
exclusions. If so, the commands would be easier to read, maintain, and
reproduce apart from GitHub Actions (e.g. during local dev/test).

Guidance from Ádám Sághy:

> our gradle task dependencies should be rather reviewed first why any
> of the excluded tasks been triggered (hence depended) for the target
> task
---
 .github/actions/setup-and-build-fineract/action.yml | 12 ++++++------
 .github/workflows/build-quality-checks.yml          | 10 +++++-----
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.github/actions/setup-and-build-fineract/action.yml b/.github/actions/setup-and-build-fineract/action.yml
index 7ef49955dd9..7434b3ca7cd 100644
--- a/.github/actions/setup-and-build-fineract/action.yml
+++ b/.github/actions/setup-and-build-fineract/action.yml
@@ -27,17 +27,17 @@ runs:
     - name: Build Avro Java SDK
       shell: bash
       working-directory: ${{ inputs.working-directory }}
-      run: ./gradlew --no-daemon :fineract-avro-schemas:buildJavaSdk -x test -x cucumber -x doc -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
+      run: ./gradlew :fineract-avro-schemas:buildJavaSdk
 
     - name: Compile Fineract Provider
       shell: bash
       working-directory: ${{ inputs.working-directory }}
-      run: ./gradlew --no-daemon :fineract-provider:compileJava -x test -x cucumber -x doc -x buildJavaSdk -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
+      run: ./gradlew :fineract-provider:compileJava
 
     - name: Generate Fineract Git Properties
       shell: bash
       working-directory: ${{ inputs.working-directory }}
-      run: ./gradlew --no-daemon :fineract-provider:generateGitProperties -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
+      run: ./gradlew :fineract-provider:generateGitProperties
 
     - name: Verify generated git.properties
       shell: bash
@@ -47,14 +47,14 @@ runs:
     - name: Build Fineract Client Java SDK
       shell: bash
       working-directory: ${{ inputs.working-directory }}
-      run: ./gradlew --no-daemon :fineract-client:buildJavaSdk -x test -x cucumber -x doc -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
+      run: ./gradlew :fineract-client:buildJavaSdk
 
     - name: Build Fineract Client Feign Java SDK
       shell: bash
       working-directory: ${{ inputs.working-directory }}
-      run: ./gradlew --no-daemon :fineract-client-feign:buildJavaSdk -x test -x cucumber -x doc -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
+      run: ./gradlew :fineract-client-feign:buildJavaSdk
 
     - name: Build Fineract
       shell: bash
       working-directory: ${{ inputs.working-directory }}
-      run: ./gradlew --no-daemon build -x test -x cucumber -x doc -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
+      run: ./gradlew build -x test -x cucumber -x doc -x javadoc -x javadocJar -x checkstyleMain -x checkstyleTest -x checkstyleJmh -x spotbugsMain -x spotbugsTest -x spotlessCheck -x spotlessApply -x rat
diff --git a/.github/workflows/build-quality-checks.yml b/.github/workflows/build-quality-checks.yml
index 1b087567bf6..209cbaaa8a0 100644
--- a/.github/workflows/build-quality-checks.yml
+++ b/.github/workflows/build-quality-checks.yml
@@ -40,7 +40,7 @@ jobs:
           validate-wrappers: true
 
       - name: Generate Javadocs
-        run: ./gradlew --no-daemon javadoc -x test -x cucumber -x doc -x buildJavaSdk
+        run: ./gradlew javadoc
 
       - name: Archive Javadoc reports
         if: failure()
@@ -82,7 +82,7 @@ jobs:
           validate-wrappers: true
 
       - name: Run Checkstyle
-        run: ./gradlew --no-daemon checkstyleMain checkstyleTest checkstyleJmh -x test -x cucumber -x doc -x javadoc -x javadocJar -x buildJavaSdk
+        run: ./gradlew checkstyleMain checkstyleTest checkstyleJmh
 
       - name: Archive Checkstyle reports
         if: failure()
@@ -124,7 +124,7 @@ jobs:
           validate-wrappers: true
 
       - name: Run RAT
-        run: ./gradlew --no-daemon rat -x test -x cucumber -x doc -x javadoc -x javadocJar -x buildJavaSdk
+        run: ./gradlew rat
 
       - name: Archive RAT reports
         if: failure()
@@ -166,7 +166,7 @@ jobs:
           validate-wrappers: true
 
       - name: Run SpotBugs
-        run: ./gradlew --no-daemon spotbugsMain spotbugsTest -x test -x cucumber -x doc -x javadoc -x javadocJar -x buildJavaSdk
+        run: ./gradlew spotbugsMain spotbugsTest
 
       - name: Archive SpotBugs reports
         if: failure()
@@ -208,4 +208,4 @@ jobs:
           validate-wrappers: true
 
       - name: Run Spotless
-        run: ./gradlew --no-daemon spotlessCheck -x test -x cucumber -x doc -x javadoc -x javadocJar -x buildJavaSdk
+        run: ./gradlew spotlessCheck