From 47975de992cdc7463b3bc3ce328ff6b9ff3bb4ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=8B=8F=E4=B9=89=E8=B6=85?= Date: Thu, 2 Apr 2026 16:37:51 +0800 Subject: [PATCH] Remove the redundant workflow completion check when handling workflow timeout events --- .../handler/WorkflowTimeoutLifecycleEventHandler.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java index 34e405125af3..8e4b5ad42429 100644 --- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java +++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java @@ -19,7 +19,6 @@ import org.apache.dolphinscheduler.dao.entity.WorkflowInstance; import org.apache.dolphinscheduler.server.master.engine.ILifecycleEventType; -import org.apache.dolphinscheduler.server.master.engine.graph.IWorkflowExecutionGraph; import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.WorkflowLifecycleEventType; import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.event.WorkflowTimeoutLifecycleEvent; import org.apache.dolphinscheduler.server.master.engine.workflow.runnable.IWorkflowExecutionRunnable; @@ -46,12 +45,6 @@ public WorkflowTimeoutLifecycleEventHandler(final WorkflowAlertManager workflowA public void handle(final IWorkflowStateAction workflowStateAction, final IWorkflowExecutionRunnable workflowExecutionRunnable, final WorkflowTimeoutLifecycleEvent workflowTimeoutLifecycleEvent) { - final IWorkflowExecutionGraph workflowExecutionGraph = workflowExecutionRunnable.getWorkflowExecutionGraph(); - if (workflowExecutionGraph.isAllTaskExecutionRunnableChainFinish()) { - // all the TaskExecutionRunnable chain in the graph is finish, means the workflow is already finished. - return; - } - final WorkflowInstance workflowInstance = workflowExecutionRunnable.getWorkflowInstance(); final boolean shouldSendAlert = workflowInstance.getWarningGroupId() != null;