Skip to content

Commit a5d5ea0

Browse files
authored
Merge pull request #41 from apache/5.0.x-patch
5.0.x patch
2 parents 28a5602 + 3e71a48 commit a5d5ea0

File tree

5 files changed

+36
-18
lines changed

5 files changed

+36
-18
lines changed

.github/workflows/build_wheels.yml

Lines changed: 31 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,32 @@ on:
66
env:
77
BUILD_TYPE: Release
88
MIN_CIBUILDWHEEL_VERSION: 2.16.2
9+
PYTHON_VERSION: 3.x
910

1011
jobs:
1112
build_sdist:
1213
name: Source distribution
1314
runs-on: ubuntu-latest
1415
steps:
15-
- uses: actions/checkout@v3
16+
- uses: actions/checkout@v4
1617

17-
- uses: actions/setup-python@v4
18+
- uses: actions/setup-python@v5
1819
name: Install Python
1920
with:
20-
python-version: '3.x'
21+
python-version: ${{ env.PYTHON_VERSION }}
2122

2223
- name: Install build package
2324
run: python -m pip install build --user
2425

2526
- name: Build sdist
2627
run: python -m build --sdist --outdir dist
2728

28-
- uses: actions/upload-artifact@v3
29+
- uses: actions/upload-artifact@v4
2930
with:
31+
name: sdist
3032
path: dist/*.tar.gz
33+
compression-level: 0 # contents are already compressed
34+
3135

3236
build_wheels:
3337
name: ${{ matrix.config.name }}
@@ -69,16 +73,16 @@ jobs:
6973

7074
steps:
7175
- name: Checkout
72-
uses: actions/checkout@v3
76+
uses: actions/checkout@v4
7377

74-
- name: Set up Python 3.x
75-
uses: actions/setup-python@v4
78+
- name: Set up Python
79+
uses: actions/setup-python@v5
7680
with:
77-
python-version: '3.x'
81+
python-version: ${{ env.PYTHON_VERSION }}
7882

7983
- name: Set up QEMU for linux/arm64 builds
8084
if: runner.os == 'Linux' && matrix.config.use-qemu == true
81-
uses: docker/setup-qemu-action@v2
85+
uses: docker/setup-qemu-action@v3
8286
with:
8387
platforms: arm64
8488

@@ -88,8 +92,25 @@ jobs:
8892
- name: Build wheels
8993
run: python -m cibuildwheel --output-dir dist
9094
env:
95+
CIBW_ENVIRONMENT_MACOS: CMAKE_OSX_ARCHITECTURES=${{ matrix.config.cibw-arch == 'macosx_x86_64' && 'x86_64' || matrix.config.cibw-arch == 'macosx_arm64' && 'arm64' || '' }}
9196
CIBW_BUILD: "*-${{ matrix.config.cibw-arch }}"
97+
MACOSX_DEPLOYMENT_TARGET: "10.14" # min supporting c++17
9298

93-
- uses: actions/upload-artifact@v3
99+
- uses: actions/upload-artifact@v4
94100
with:
101+
name: wheels-${{ matrix.config.os }}-${{ matrix.config.cibw-arch }}
95102
path: ./dist/*.whl
103+
compression-level: 0 # contents are already compressed
104+
105+
106+
aggregate_artifacts:
107+
name: Aggregate artifacts
108+
runs-on: ubuntu-latest
109+
needs: [build_sdist, build_wheels]
110+
steps:
111+
- name: Merge Artifacts
112+
uses: actions/upload-artifact/merge@v4
113+
with:
114+
name: python_wheels
115+
compression-level: 0
116+
delete-merged: true

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ jobs:
3535

3636
steps:
3737
- name: Checkout
38-
uses: actions/checkout@v3
38+
uses: actions/checkout@v4
3939
- name: Set up Python 3.x
40-
uses: actions/setup-python@v4
40+
uses: actions/setup-python@v5
4141
# 3.x uses the latest minor version of python3. This may break briefly when there is a new version
4242
# but dependent libraries (e.g. numpy) have not yet released a compatible update.
4343
# May need to enable version pinning (e.g. 3.10) temporarily at times.

.github/workflows/sphinx.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- name: Checkout
14-
uses: actions/checkout@v3
14+
uses: actions/checkout@v4
1515
- name: Install Python
16-
uses: actions/setup-python@v4
16+
uses: actions/setup-python@v5
1717
with:
1818
python-version: '3.x'
1919
- name: Install Datasketches and Sphinx

pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,3 @@ before-build = "yum remove -y cmake"
3636

3737
[tool.cibuildwheel.macos]
3838
archs = ["x86_64", "arm64"]
39-
40-
# Minimum version for proper C++17 support on MacOS
41-
environment = { MACOSX_DEPLOYMENT_TARGET = "10.14" }

version.cfg.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5.0.0
1+
5.0.1

0 commit comments

Comments
 (0)