Skip to content

optimize: cache common entity lookups in CallContext during VM deployment #11549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shwstppr wants to merge 7 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'apache/main' into cache-findbyid-deploy…

7f22ac0
Select commit
Loading
Failed to load commit list.
Refresh
Draft

optimize: cache common entity lookups in CallContext during VM deployment #11549

Merge remote-tracking branch 'apache/main' into cache-findbyid-deploy…
7f22ac0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2026 in 0s

17.89% (+0.01%) compared to ffb8b91

View this Pull Request on Codecov

17.89% (+0.01%) compared to ffb8b91

Details

Codecov Report

❌ Patch coverage is 39.70588% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.89%. Comparing base (ffb8b91) to head (7f22ac0).

Files with missing lines Patch % Lines
...a/com/cloud/network/router/CommandSetupHelper.java 20.00% 28 Missing ⚠️
...c/main/java/com/cloud/utils/db/GenericDaoBase.java 0.00% 19 Missing ⚠️
...om/cloud/network/element/VirtualRouterElement.java 23.80% 16 Missing ⚠️
.../apache/cloudstack/context/RequestEntityCache.java 47.82% 5 Missing and 7 partials ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 44.44% 10 Missing ⚠️
...n/java/com/cloud/capacity/CapacityManagerImpl.java 0.00% 8 Missing ⚠️
...om/cloud/deploy/DeploymentPlanningManagerImpl.java 80.48% 5 Missing and 3 partials ⚠️
...torage/allocator/AbstractStoragePoolAllocator.java 0.00% 4 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 40.00% 3 Missing ⚠️
...ava/org/apache/cloudstack/context/CallContext.java 50.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11549      +/-   ##
============================================
+ Coverage     17.88%   17.89%   +0.01%     
- Complexity    16072    16085      +13     
============================================
  Files          5935     5936       +1     
  Lines        532338   532443     +105     
  Branches      65086    65103      +17     
============================================
+ Hits          95191    95273      +82     
+ Misses       426500   426494       -6     
- Partials      10647    10676      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov