Skip to content

Commit e7d72fe

Browse files
committed
Fix host metrics on overprovisioning change
1 parent ef1aaa0 commit e7d72fe

1 file changed

Lines changed: 10 additions & 22 deletions

File tree

server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -704,22 +704,16 @@ public void updateCapacityForHost(final Host host) {
704704
so = _offeringsDao.findByIdIncludingRemoved(vm.getServiceOfferingId());
705705
}
706706
if (so.isDynamic()) {
707-
usedMemory +=
708-
((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
709-
clusterRamOvercommitRatio;
707+
usedMemory += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L;
710708
if(vmDetails.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {
711-
usedCpu +=
712-
((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
713-
clusterCpuOvercommitRatio;
709+
usedCpu += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()));
714710
} else {
715-
usedCpu +=
716-
((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * so.getSpeed()) / cpuOvercommitRatio) *
717-
clusterCpuOvercommitRatio;
711+
usedCpu += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * so.getSpeed();
718712
}
719713
usedCpuCore += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name()));
720714
} else {
721-
usedMemory += ((so.getRamSize() * 1024L * 1024L) / ramOvercommitRatio) * clusterRamOvercommitRatio;
722-
usedCpu += ((so.getCpu() * so.getSpeed()) / cpuOvercommitRatio) * clusterCpuOvercommitRatio;
715+
usedMemory += so.getRamSize() * 1024L * 1024L;
716+
usedCpu += so.getCpu() * so.getSpeed();
723717
usedCpuCore += so.getCpu();
724718
}
725719
}
@@ -748,22 +742,16 @@ public void updateCapacityForHost(final Host host) {
748742
so = _offeringsDao.findByIdIncludingRemoved(vm.getServiceOfferingId());
749743
}
750744
if (so.isDynamic()) {
751-
reservedMemory +=
752-
((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
753-
clusterRamOvercommitRatio;
745+
reservedMemory += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L;
754746
if(vmDetails.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {
755-
reservedCpu +=
756-
((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
757-
clusterCpuOvercommitRatio;
747+
reservedCpu += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()));
758748
} else {
759-
reservedCpu +=
760-
((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * so.getSpeed()) / cpuOvercommitRatio) *
761-
clusterCpuOvercommitRatio;
749+
reservedCpu += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * so.getSpeed();
762750
}
763751
reservedCpuCore += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name()));
764752
} else {
765-
reservedMemory += ((so.getRamSize() * 1024L * 1024L) / ramOvercommitRatio) * clusterRamOvercommitRatio;
766-
reservedCpu += (so.getCpu() * so.getSpeed() / cpuOvercommitRatio) * clusterCpuOvercommitRatio;
753+
reservedMemory += so.getRamSize() * 1024L * 1024L;
754+
reservedCpu += so.getCpu() * so.getSpeed();
767755
reservedCpuCore += so.getCpu();
768756
}
769757
} else {

0 commit comments

Comments
 (0)