review

sureshanaparti · sureshanaparti · commit 225341c116e8 · 2026-01-16T16:18:48.000+05:30
diff --git a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
@@ -1566,7 +1566,9 @@ protected String getStoragePoolNonDestroyedVolumesLog(long storagePoolId) {
         for (VolumeVO vol : nonDestroyedVols) {
             if (vol.getInstanceId() != null) {
                 volInstance = _vmInstanceDao.findById(vol.getInstanceId());
-                logMessageInfo.add(String.format("Volume [%s] (attached to VM [%s])", vol.getUuid(), volInstance.getUuid()));
+                if (volInstance != null) {
+                    logMessageInfo.add(String.format("Volume [%s] (attached to VM [%s])", vol.getUuid(), volInstance.getUuid()));
+                }
             }
         }
         sb.append(String.join(", ", logMessageInfo));

Original file line number	Diff line number	Diff line change
`@@ -1566,7 +1566,9 @@ protected String getStoragePoolNonDestroyedVolumesLog(long storagePoolId) {`
`1566`	`1566`	`for (VolumeVO vol : nonDestroyedVols) {`
`1567`	`1567`	`if (vol.getInstanceId() != null) {`
`1568`	`1568`	`volInstance = _vmInstanceDao.findById(vol.getInstanceId());`
`1569`		`- logMessageInfo.add(String.format("Volume [%s] (attached to VM [%s])", vol.getUuid(), volInstance.getUuid()));`
	`1569`	`+ if (volInstance != null) {`
	`1570`	`+ logMessageInfo.add(String.format("Volume [%s] (attached to VM [%s])", vol.getUuid(), volInstance.getUuid()));`
	`1571`	`+ }`
`1570`	`1572`	`}`
`1571`	`1573`	`}`
`1572`	`1574`	`sb.append(String.join(", ", logMessageInfo));`