Update server/src/main/java/org/apache/cloudstack/storage/template/VnfTemplateManagerImpl.java

weizhouapache · Copilot · web-flow · commit 0bfc65aa008b · 2026-01-22T12:45:05.000+01:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/server/src/main/java/org/apache/cloudstack/storage/template/VnfTemplateManagerImpl.java b/server/src/main/java/org/apache/cloudstack/storage/template/VnfTemplateManagerImpl.java
@@ -226,7 +226,7 @@ private void validateVnfApplianceNetworksMap(VirtualMachineTemplate template, Ma
         }
         List<VnfTemplateNicVO> vnfNics = vnfTemplateNicDao.listByTemplateId(template.getId());
         for (VnfTemplateNicVO vnfNic : vnfNics) {
-            if (vnfNic.isRequired() && vmNetworkMap.size() <= vnfNic.getDeviceId()) {
+            if (vnfNic.isRequired() && !vmNetworkMap.containsKey(vnfNic.getDeviceId())) {
                 throw new InvalidParameterValueException("VNF nic is required but not found: " + vnfNic);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ private void validateVnfApplianceNetworksMap(VirtualMachineTemplate template, Ma`
`226`	`226`	`}`
`227`	`227`	`List<VnfTemplateNicVO> vnfNics = vnfTemplateNicDao.listByTemplateId(template.getId());`
`228`	`228`	`for (VnfTemplateNicVO vnfNic : vnfNics) {`
`229`		`- if (vnfNic.isRequired() && vmNetworkMap.size() <= vnfNic.getDeviceId()) {`
	`229`	`+ if (vnfNic.isRequired() && !vmNetworkMap.containsKey(vnfNic.getDeviceId())) {`
`230`	`230`	`throw new InvalidParameterValueException("VNF nic is required but not found: " + vnfNic);`
`231`	`231`	`}`
`232`	`232`	`}`