From cf4179fc8760676a260831580703eaec0650f480 Mon Sep 17 00:00:00 2001 From: Mayank Aggarwal Date: Sat, 28 Mar 2026 23:33:45 +0530 Subject: [PATCH] [v3-2-test] Fix Docs menu REST API link visibility when API docs are disabled (#64359) (cherry picked from commit eab43f2db8b073b585149f2b3fdd4838f5e82187) Co-authored-by: Mayank Aggarwal --- .../ui/src/layouts/Nav/DocsButton.test.tsx | 56 +++++++++++++++++++ .../airflow/ui/src/layouts/Nav/DocsButton.tsx | 2 +- 2 files changed, 57 insertions(+), 1 deletion(-) create mode 100644 airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.test.tsx diff --git a/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.test.tsx b/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.test.tsx new file mode 100644 index 0000000000000..20b25b159380f --- /dev/null +++ b/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.test.tsx @@ -0,0 +1,56 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import "@testing-library/jest-dom"; +import { fireEvent, render, screen } from "@testing-library/react"; +import { beforeEach, describe, expect, it, vi } from "vitest"; + +import { Wrapper } from "src/utils/Wrapper"; + +import { DocsButton } from "./DocsButton"; + +const mockConfig: Record = { + enable_swagger_ui: true, +}; + +vi.mock("src/queries/useConfig", () => ({ + useConfig: (key: string) => mockConfig[key], +})); + +describe("DocsButton", () => { + beforeEach(() => { + mockConfig.enable_swagger_ui = true; + }); + + it("hides the REST API reference when API docs are disabled", async () => { + render(, { wrapper: Wrapper }); + + fireEvent.click(screen.getByRole("button", { name: /nav.docs/iu })); + + expect(await screen.findByText("docs.documentation")).toBeInTheDocument(); + expect(screen.queryByText("docs.restApiReference")).toBeNull(); + }); + + it("shows the REST API reference when API docs are enabled", async () => { + render(, { wrapper: Wrapper }); + + fireEvent.click(screen.getByRole("button", { name: /nav.docs/iu })); + + expect(await screen.findByText("docs.restApiReference")).toBeInTheDocument(); + }); +}); diff --git a/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.tsx b/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.tsx index 3af4e7f93a636..9156f77a51295 100644 --- a/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.tsx +++ b/airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.tsx @@ -65,7 +65,7 @@ export const DocsButton = ({ {links - .filter((link) => !(!showAPIDocs && link.href === "/docs")) + .filter((link) => !(!showAPIDocs && link.key === "restApiReference")) .map((link) => (