Skip to content

Commit 0750c6b

Browse files
committed
fix: resolve conflicts with main branch
- Update import pattern for NOTSET and ArgNotSet to support both Airflow versions - Fix parametrize decorators to use tuples instead of strings (PT006 rule)
1 parent 4da41f4 commit 0750c6b

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,12 @@
4242
from airflow.providers.standard.triggers.external_task import DagStateTrigger
4343
from airflow.providers.standard.version_compat import AIRFLOW_V_3_0_PLUS, BaseOperator
4444
from airflow.utils.state import DagRunState
45-
from airflow.utils.types import NOTSET, ArgNotSet, DagRunType
45+
from airflow.utils.types import DagRunType
46+
47+
try:
48+
from airflow.sdk.definitions._internal.types import NOTSET, ArgNotSet
49+
except ImportError:
50+
from airflow.utils.types import NOTSET, ArgNotSet # type: ignore[attr-defined,no-redef]
4651

4752
XCOM_LOGICAL_DATE_ISO = "trigger_logical_date_iso"
4853
XCOM_RUN_ID = "trigger_run_id"

providers/standard/tests/unit/standard/operators/test_trigger_dagrun.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ def test_trigger_dagrun_with_reset_dag_run_false(self, dag_maker):
624624
assert len(dagruns) == 2
625625

626626
@pytest.mark.parametrize(
627-
"trigger_run_id, trigger_logical_date",
627+
("trigger_run_id", "trigger_logical_date"),
628628
[
629629
(None, DEFAULT_DATE),
630630
("dummy_run_id", None),
@@ -674,7 +674,7 @@ def test_trigger_dagrun_with_skip_when_already_exists(self, dag_maker):
674674
assert dr.get_task_instance("test_task").state == TaskInstanceState.SKIPPED
675675

676676
@pytest.mark.parametrize(
677-
"trigger_run_id, trigger_logical_date, expected_dagruns_count",
677+
("trigger_run_id", "trigger_logical_date", "expected_dagruns_count"),
678678
[
679679
(None, DEFAULT_DATE, 1),
680680
(None, None, 2),

0 commit comments

Comments
 (0)