From 853161e880a57d7a624ef2528e145cc8cb248228 Mon Sep 17 00:00:00 2001 From: mhidas Date: Mon, 15 Sep 2025 17:17:46 +1000 Subject: [PATCH 1/2] remove handling of var attribute types from example (now done in DatasetTemplate class) --- examples/rottnest.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/examples/rottnest.py b/examples/rottnest.py index e215dbb..abc1908 100644 --- a/examples/rottnest.py +++ b/examples/rottnest.py @@ -40,15 +40,6 @@ if '_data' not in var: var['_data'] = df[name].values -# convert valid_min/max attributes to match variable type -# TODO: make this a template method -for name, var in template.variables.items(): - var_type = var['_datatype'] - for attr in ('valid_min', 'valid_max'): - if attr in var: - var[attr] = np.array(var[attr], dtype=var_type) - - # update range attributes template.add_extent_attributes() From e7b8a238e57272321dbafaddf3e29190340efe9a Mon Sep 17 00:00:00 2001 From: mhidas Date: Mon, 15 Sep 2025 17:18:18 +1000 Subject: [PATCH 2/2] add QC variable in rottenst example --- examples/rottnest.json | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/examples/rottnest.json b/examples/rottnest.json index fd51035..bae0bb6 100644 --- a/examples/rottnest.json +++ b/examples/rottnest.json @@ -65,7 +65,18 @@ "coordinates": "TIME PRES_REL DEPTH LATITUDE LONGITUDE", "_FillValue": 999999.0, "valid_min": -2.5, - "valid_max": 40.0 + "valid_max": 40.0, + "ancillary_variables": "TEMP_quality_control" + }, + "TEMP_quality_control": { + "_dimensions": ["TIME"], + "_datatype": "b", + "standard_name": "sea_water_temperature status_flag", + "long_name": "quality flag for sea_water_temperature", + "quality_control_conventions": "IMOS standard flags", + "flag_meanings": "No_QC_performed Good_data Probably_good_data Bad_data_that_are_potentially_correctable Bad_data Value_changed Not_used Not_used Not_used Missing_value", + "flag_values": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9], + "_FillValue": 99 } }, "title": "Sample data from Rottnest Island NRS",