Skip to content

chore: v1 implementation of beam stub #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacobrkerstetter merged 42 commits into from
Dec 8, 2025
Merged

chore: v1 implementation of beam stub #2444

jacobrkerstetter merged 42 commits into from
Dec 8, 2025

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Dec 5, 2025 •
edited by jacobrkerstetter
Loading

Description

V1 implementation of beam stub.
Does not address the following issues

  1. DeleteBeamProfile seems to have disappeared from v1 protos
  2. Need to make sure that we have a consistent pattern for creation that may return multiple entities (not expected in the return of the v0 method)

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 27 commits February 17, 2025 14:31
@pyansys-ci-bot
chore: update CHANGELOG for v0.9.0 (#1753)
97eb31a
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
1547839
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
5a48878
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
4109456
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
e00316b
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
1afa37a
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
7c595bb
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
6a23076
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
62ca792
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
40c19c1
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
40a13e2
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
269ec5b
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
6217f4a
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
7a728c4
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
6c462de
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
3611a99
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
c5a4e86
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
ecd7567
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
8b628a2
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
f55daa8
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
38324c1
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
18f6686
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
6147028
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
85a9d0b
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
a3de5c0
@smereu
Merge branch 'main' of https://github.com/ansys/pyansys-geometry
df4f408
@smereu
v1 implementation of beam.py
b76d58b
smereu and others added 2 commits December 5, 2025 13:09
@smereu @jacobrkerstetter
Update src/ansys/geometry/core/_grpc/_services/v1/beams.py
5145e88 
Co-authored-by: Jacob Kerstetter <83893427+jacobrkerstetter@users.noreply.github.com>
@smereu
Merge branch 'main' into ci/v1_implementation_of_beam_stub
d3d826e
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Dec 5, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Dec 5, 2025
RobPasMue
RobPasMue previously requested changes Dec 7, 2025
View reviewed changes
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Dec 8, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Dec 8, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Dec 8, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) December 8, 2025 20:27
@jacobrkerstetter jacobrkerstetter merged commit 71d3606 into main Dec 8, 2025
49 of 50 checks passed
@jacobrkerstetter jacobrkerstetter deleted the ci/v1_implementation_of_beam_stub branch December 8, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jacobrkerstetter jacobrkerstetter jacobrkerstetter approved these changes

@b-matteo b-matteo Awaiting requested review from b-matteo

@david-gorman david-gorman Awaiting requested review from david-gorman

@umutsoysalansys umutsoysalansys Awaiting requested review from umutsoysalansys

Assignees

@smereu smereu

Labels

maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smereu @RobPasMue @jacobrkerstetter @pyansys-ci-bot