fix: restore connecting to external gnetcli_server via url#80
Open
vaneuk wants to merge 1 commit into
Open
Conversation
vaneuk
changed the title
urlurl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 87eacdf ("Gnetcli starter") rewrote
make_apito always fork a localgnetcli_serverviaGnetcliStarter. Theurlfield inAppSettingsisstill read but never used, so configs that point at an externally-running
server crash with
FileNotFoundError: 'gnetcli_server'.Restores the pre-87eacdf branch in
ApiMaker.make_api: whenconf.urlisset, connect directly; otherwise spawn a local server as today.
Changes
gnetcli_adapter.py: branch onconf.urlinmake_api.tests/test_methods.py: assertGnetcliStarteris not invoked whenurlis set.README.md: example for the external-server case.