feat: Add Telnet support (dev_port and streamer_type)#75
Open
vadvolo wants to merge 3 commits into
Open
Conversation
vadvolo
commented
Nov 23, 2025
vadvolo
commented
- Add dev_port and streamer_type to AppSettings
- Add get_streamer_type method to convert string to proto enum
- Update GnetcliFetcher and GnetcliDeployer with new parameters
- Pass port and streamer_type to all HostParams calls
- Add dev_port and streamer_type to AppSettings - Add get_streamer_type method to convert string to proto enum - Update GnetcliFetcher and GnetcliDeployer with new parameters - Pass port and streamer_type to all HostParams calls 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
azryve
reviewed
May 23, 2026
| """Convert string streamer_type to proto enum value""" | ||
| if self.streamer_type == "telnet": | ||
| return pb.StreamerType.StreamerType_telnet | ||
| return pb.StreamerType.StreamerType_ssh |
Contributor
There was a problem hiding this comment.
Lets be on a defensive side and use StreamerType_ssh only when None or "ssh" is passed and raise an exception otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.