feat: adding telnet streamer support#302
Open
vadvolo wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Telnet Streamer Support with StreamerType Selection
Summary
This PR implements Telnet protocol support as an alternative connection method to the existing SSH streamer, allowing gnetcli to connect to legacy network equipment that may not support SSH. The implementation includes a new StreamerType enum for explicit protocol selection and comprehensive documentation.
Key Changes
Core Implementation
Protocol Support
StreamerType_ssh = 0) - Default, secure connection with full feature setStreamerType_telnet = 1) - Plain text connection for legacy equipmentArchitecture Improvements
Testing & Documentation
docs/streamer_types.mdwith usage examplesAPI Changes
Backward Compatibility
Fully backward compatible - existing code continues to work unchanged
Example Usage
This implementation provides a robust foundation for multi-protocol support while maintaining the security-first approach with SSH as the default option.
Testing
Annet Config
Diff Result
Cisco Telnet
Mikrotik with SSH port 10022
Switch context to
ssh-10022Result