Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 67ee007

Browse files
chalinwardbell
authored andcommitted
chore(docs build): add flag to control log output level
closes #1823 Gulp targets like `check-deploy` and `serve-and-sync-devguide` are quite verbose. This PR allows the `dgeni` logging level to be controlled using the `--dgeni-log` flag. E.g., use `--dgen-log="error"` to see only errors. Also sets log level to "error" when gulp is silent and log level for createShredMapPackage
1 parent 37b377d commit 67ee007

File tree

4 files changed

+32
-30
lines changed

4 files changed

+32
-30
lines changed

gulpfile.js

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,27 @@ var exampleZipper = require(path.resolve(TOOLS_PATH, '_example-zipper/exampleZip
4646
var plunkerBuilder = require(path.resolve(TOOLS_PATH, 'plunker-builder/plunkerBuilder'));
4747
var fsUtils = require(path.resolve(TOOLS_PATH, 'fs-utils/fsUtils'));
4848

49+
const isSilent = !!argv.silent;
50+
if (isSilent) gutil.log = gutil.noop;
51+
const _dgeniLogLevel = argv.dgeniLog || (isSilent ? 'error' : 'info');
4952

5053
var _devguideShredOptions = {
5154
examplesDir: path.join(DOCS_PATH, '_examples'),
5255
fragmentsDir: path.join(DOCS_PATH, '_fragments'),
53-
zipDir: path.join(RESOURCES_PATH, 'zips')
56+
zipDir: path.join(RESOURCES_PATH, 'zips'),
57+
logLevel: _dgeniLogLevel
5458
};
5559

5660
var _devguideShredJadeOptions = {
57-
jadeDir: DOCS_PATH
58-
61+
jadeDir: DOCS_PATH,
62+
logLevel: _dgeniLogLevel
5963
};
6064

6165
var _apiShredOptions = {
6266
examplesDir: path.join(ANGULAR_PROJECT_PATH, 'modules/@angular/examples'),
6367
fragmentsDir: path.join(DOCS_PATH, '_fragments/_api'),
64-
zipDir: path.join(RESOURCES_PATH, 'zips/api')
68+
zipDir: path.join(RESOURCES_PATH, 'zips/api'),
69+
logLevel: _dgeniLogLevel
6570
};
6671

6772
var _excludePatterns = ['**/node_modules/**', '**/typings/**', '**/packages/**'];
@@ -625,7 +630,7 @@ gulp.task('_shred-devguide-examples', ['_shred-clean-devguide', '_copy-example-b
625630
});
626631

627632
gulp.task('_shred-devguide-shared-jade', ['_shred-clean-devguide-shared-jade', '_copy-example-boilerplate'], function() {
628-
return docShredder.shred( _devguideShredJadeOptions);
633+
return docShredder.shred(_devguideShredJadeOptions);
629634
});
630635

631636
gulp.task('_shred-clean-devguide-shared-jade', function(cb) {
@@ -646,7 +651,7 @@ gulp.task('_shred-clean-devguide', function(cb) {
646651

647652
gulp.task('_shred-api-examples', ['_shred-clean-api'], function() {
648653
checkAngularProjectPath();
649-
return docShredder.shred( _apiShredOptions);
654+
return docShredder.shred(_apiShredOptions);
650655
});
651656

652657
gulp.task('_shred-clean-api', function(cb) {
@@ -1023,7 +1028,8 @@ function buildApiDocs(targetLanguage) {
10231028
try {
10241029
// Build a specialized package to generate different versions of the API docs
10251030
var package = new Package('apiDocs', [require(path.resolve(TOOLS_PATH, 'api-builder/angular.io-package'))]);
1026-
package.config(function(targetEnvironments, writeFilesProcessor, readTypeScriptModules) {
1031+
package.config(function(log, targetEnvironments, writeFilesProcessor, readTypeScriptModules) {
1032+
log.level = _dgeniLogLevel;
10271033
ALLOWED_LANGUAGES.forEach(function(target) { targetEnvironments.addAllowed(target); });
10281034
if (targetLanguage) {
10291035
targetEnvironments.activate(targetLanguage);
@@ -1058,7 +1064,8 @@ function buildShredMaps(shouldWrite) {
10581064
fragmentsDir: _devguideShredOptions.fragmentsDir,
10591065
jadeDir: './public/docs',
10601066
outputDir: './public/docs',
1061-
writeFilesEnabled: shouldWrite
1067+
writeFilesEnabled: shouldWrite,
1068+
logLevel: _dgeniLogLevel
10621069
};
10631070
return docShredder.buildShredMap(options).then(function(docs) {
10641071
return docs;

tools/api-builder/angular.io-package/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,7 @@ module.exports = new Package('angular.io', [basePackage, targetPackage, cheatshe
155155
]));
156156
})
157157

158-
.config(function(filterUnwantedDecorators, log) {
159-
log.level = 'info';
158+
.config(function(filterUnwantedDecorators) {
160159
filterUnwantedDecorators.decoratorsToIgnore = [
161160
'CONST',
162161
'IMPLEMENTS',

tools/api-builder/docs-package/index.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@ module.exports = new Package('angular-v2-docs', [jsdocPackage, nunjucksPackage,
2020
.processor(require('./processors/addNotYetDocumentedProperty'))
2121
.processor(require('./processors/createDecoratorDocs'))
2222

23-
// Configure the log service
24-
.config(function(log) {
25-
log.level = 'info';
26-
})
27-
2823
.config(function(parseTagsProcessor) {
2924
parseTagsProcessor.tagDefinitions.push({ name: 'internal', transforms: function() { return true; } });
3025
parseTagsProcessor.tagDefinitions.push({ name: 'syntax' });

tools/doc-shredder/doc-shredder.js

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ var _ = require('lodash');
66
var globby = require('globby');
77
var ignoreDirs = ['**/node_modules/**', '**/dist/**', '**/typings/**'];
88

9+
var _getLogLevel = function (options) { return options.logLevel || 'info'; }
10+
911
var shred = function(shredOptions) {
1012
try {
1113
var pkg;
@@ -14,7 +16,7 @@ var shred = function(shredOptions) {
1416
} else {
1517
pkg = createShredExamplePackage(shredOptions);
1618
}
17-
var dgeni = new Dgeni([ pkg]);
19+
var dgeni = new Dgeni([pkg]);
1820
return dgeni.generate();
1921
} catch(err) {
2022
console.log(err);
@@ -31,7 +33,8 @@ var shredSingleExampleDir = function(shredOptions, fileDir) {
3133
var options = {
3234
includeSubdirs: true,
3335
examplesDir: examplesDir,
34-
fragmentsDir: fragmentsDir
36+
fragmentsDir: fragmentsDir,
37+
logLevel: _getLogLevel(shredOptions)
3538
}
3639
var cleanPath = path.join(fragmentsDir, '*.*')
3740
return del([ cleanPath, '!**/*.ovr.*']).then(function(paths) {
@@ -49,7 +52,8 @@ var shredSingleDir = function(shredOptions, filePath) {
4952
var options = {
5053
includeSubdirs: false,
5154
examplesDir: examplesDir,
52-
fragmentsDir: fragmentsDir
55+
fragmentsDir: fragmentsDir,
56+
logLevel: _getLogLevel(shredOptions)
5357
}
5458
var cleanPath = path.join(fragmentsDir, '*.*')
5559
return del([ cleanPath, '!**/*.ovr.*']).then(function(paths) {
@@ -66,7 +70,8 @@ var shredSingleJadeDir = function(shredOptions, filePath) {
6670

6771
var options = {
6872
includeSubdirs: false,
69-
jadeDir: jadeDir
73+
jadeDir: jadeDir,
74+
logLevel: _getLogLevel(shredOptions)
7075
}
7176
// var cleanPath = path.join(jadeDir, '_.*.jade')
7277
//return delPromise([ cleanPath]).then(function(paths) {
@@ -105,12 +110,12 @@ function createShredExamplePackage(shredOptions) {
105110
initializePackage(pkg)
106111
.factory(require('./fileReaders/regionFileReader'))
107112
.processor(require('./processors/renderAsMarkdownProcessor'))
108-
109113
.config(function(readFilesProcessor, regionFileReader) {
110114
readFilesProcessor.fileReaders = [regionFileReader];
111115
})
112116
// default configs - may be overridden
113-
.config(function(readFilesProcessor) {
117+
.config(function(log, readFilesProcessor) {
118+
log.level = _getLogLevel(shredOptions);
114119
// Specify the base path used when resolving relative paths to source and output files
115120
readFilesProcessor.basePath = "/";
116121

@@ -128,7 +133,7 @@ function createShredExamplePackage(shredOptions) {
128133
// this just uses globby to 'preglob' the include files ( and exclude the node_modules).
129134
var includeFiles = globby.sync( includeFiles, { ignore: ignoreDirs } );
130135

131-
console.log(`Shredding ${includeFiles.length} files inside ${shredOptions.examplesDir}`);
136+
log.info(`Shredding ${includeFiles.length} files inside ${shredOptions.examplesDir}`);
132137

133138
readFilesProcessor.sourceFiles = [ {
134139
// Process all candidate files in `src` and its subfolders ...
@@ -159,7 +164,8 @@ function createShredJadePackage(shredOptions) {
159164
.factory(require('./fileReaders/regionFileReader'))
160165
.processor(require('./processors/renderAsJadeProcessor'))
161166

162-
.config(function(readFilesProcessor, regionFileReader) {
167+
.config(function(log, readFilesProcessor, regionFileReader) {
168+
log.level = _getLogLevel(shredOptions);
163169
readFilesProcessor.fileReaders = [regionFileReader];
164170
})
165171
// default configs - may be overridden
@@ -211,7 +217,8 @@ var createShredMapPackage = function(mapOptions) {
211217
.config(function(shredMapProcessor) {
212218
shredMapProcessor.options = options;
213219
})
214-
.config(function(readFilesProcessor, extractPathsReader ) {
220+
.config(function(log, readFilesProcessor, extractPathsReader ) {
221+
log.level = _getLogLevel(mapOptions);
215222
readFilesProcessor.fileReaders = [ extractPathsReader];
216223
})
217224
// default configs - may be overridden
@@ -281,8 +288,6 @@ var createShredMapPackage = function(mapOptions) {
281288
//});
282289
});
283290

284-
285-
286291
return pkg;
287292
}
288293

@@ -334,8 +339,4 @@ function initializePackage(pkg) {
334339
.processor({ name: 'docs-rendered', $runAfter: ['rendering-docs'] })
335340
.processor({ name: 'writing-files', $runAfter: ['docs-rendered'] })
336341
.processor({ name: 'files-written', $runAfter: ['writing-files'] })
337-
.config(function(log) {
338-
// Set logging level
339-
log.level = 'info';
340-
})
341342
}

0 commit comments

Comments
 (0)