refactor(@angular-devkit/core): remove custom json parser

With this change we replace the workspace reader and write to use `jsonc-parser` instead of our custom build JSON parser

Author: alan-agius4

goldens/public-api/angular_devkit/core/index.md

@@ -366,7 +366,7 @@ export type DeepReadonlyObject<T> = {
 };
 
 // @public (undocumented)
-type DefinitionCollectionListener<V extends object> = (name: string, action: 'add' | 'remove' | 'replace', newValue: V | undefined, oldValue: V | undefined, collection: DefinitionCollection<V>) => void;
+type DefinitionCollectionListener<V extends object> = (name: string, newValue: V | undefined, collection: DefinitionCollection<V>) => void;
 
 // @public (undocumented)
 export class DependencyNotFoundException extends BaseException {

packages/angular/cli/src/utilities/json-file.ts

@@ -87,6 +87,7 @@ export class JSONFile {
 
     const edits = modify(this.content, jsonPath, value, {
       getInsertionIndex,
+      // TODO: use indentation from original file.
       formattingOptions: {
         insertSpaces: true,
         tabSize: 2,

packages/angular_devkit/core/BUILD.bazel

@@ -39,7 +39,7 @@ ts_library(
         "@npm//ajv",
         "@npm//ajv-formats",
         "@npm//fast-json-stable-stringify",
-        "@npm//magic-string",
+        "@npm//jsonc-parser",
         "@npm//rxjs",
         "@npm//source-map",  # @external
         # @node_module: typescript:es2015.proxy
@@ -71,7 +71,6 @@ jasmine_node_test(
     deps = [
         # @node_module: ajv
         # @node_module: fast_json_stable_stringify
-        # @node_module: magic_string
         # @node_module: source_map
     ],
 )

packages/angular_devkit/core/package.json

@@ -11,7 +11,7 @@
     "ajv-formats": "2.1.1",
     "ajv": "8.11.0",
     "fast-json-stable-stringify": "2.1.0",
-    "magic-string": "0.26.1",
+    "jsonc-parser": "3.0.0",
     "rxjs": "6.6.7",
     "source-map": "0.7.3"
   },