refactor: clean up several files

Most of these changes are requires for TS 4 update

Author: alan-agius4

packages/angular/cli/lib/init.ts

@@ -155,7 +155,6 @@ if (process.env['NG_CLI_PROFILING']) {
   try {
     standardInput = process.stdin;
   } catch (e) {
-    delete process.stdin;
     process.stdin = new Duplex();
     standardInput = process.stdin;
   }

packages/angular/cli/models/analytics.ts

@@ -139,12 +139,7 @@ function _getRamSize() {
  * @private
  */
 function _getNodeVersion() {
-  // We use any here because p.release is a new Node construct in Node 10 (and our typings are the
-  // minimal version of Node we support).
-  const p = process as any; // tslint:disable-line:no-any
-  const name =
-    (typeof p.release == 'object' && typeof p.release.name == 'string' && p.release.name) ||
-    process.argv0;
+  const name = process.release.name || process.argv0;
 
   return name + ' ' + process.version;
 }
@@ -590,9 +585,7 @@ export async function getWorkspaceAnalytics(): Promise<UniversalAnalytics | unde
   analyticsDebug('getWorkspaceAnalytics');
   try {
     const globalWorkspace = await getWorkspace('local');
-    const analyticsConfig: string | undefined | null | { uid?: string } = globalWorkspace
-      && globalWorkspace.getCli()
-      && globalWorkspace.getCli()['analytics'];
+    const analyticsConfig: string | undefined | null | { uid?: string } = globalWorkspace?.getCli()['analytics'];
     analyticsDebug('Workspace Analytics config found: %j', analyticsConfig);
 
     if (analyticsConfig === false) {
@@ -645,8 +638,7 @@ export async function getSharedAnalytics(): Promise<UniversalAnalytics | undefin
   // If anything happens we just keep the NOOP analytics.
   try {
     const globalWorkspace = await getWorkspace('global');
-    const analyticsConfig =
-      globalWorkspace && globalWorkspace.getCli() && globalWorkspace.getCli()['analyticsSharing'];
+    const analyticsConfig = globalWorkspace?.getCli()['analyticsSharing'];
 
     if (!analyticsConfig || !analyticsConfig.tracking || !analyticsConfig.uuid) {
       return undefined;

packages/angular/cli/utilities/json-schema.ts

@@ -35,10 +35,8 @@ function _getEnumFromValue<E, T extends E[keyof E]>(
     return defaultValue;
   }
 
-  if (Object.values(enumeration).indexOf(value) !== -1) {
-    // TODO: this should be unknown
-    // tslint:disable-next-line:no-any
-    return value as any as T;
+  if (Object.values(enumeration).includes(value)) {
+    return value as unknown as T;
   }
 
   return defaultValue;

packages/angular_devkit/architect_cli/bin/architect.ts

@@ -84,7 +84,7 @@ async function _executeTarget(
   const targetSpec = { project, target, configuration };
 
   delete argv['help'];
-  delete argv['_'];
+  argv['_'] = [];
 
   const logger = new logging.Logger('jobs');
   const logs: logging.LogEntry[] = [];

packages/angular_devkit/schematics_cli/bin/schematics.ts

@@ -267,7 +267,8 @@ export async function main({
       return argv._;
     }
   });
-  delete parsedArgs._;
+
+  parsedArgs._  = [];
 
   // Add prompts.
   if (argv['interactive'] && isTTY()) {

packages/ngtools/webpack/src/transformers/make_transform.ts

@@ -99,8 +99,9 @@ export function makeTransform(
 // If TS sees an empty decorator array, it will still emit a `__decorate` call.
 //    This seems to be a TS bug.
 function cleanupDecorators(node: ts.Node) {
-  if (node.decorators && node.decorators.length === 0) {
-    node.decorators = undefined;
+  if (node.decorators?.length === 0) {
+    // tslint:disable-next-line:no-any
+    (node as any).decorators = undefined;
   }
 
   ts.forEachChild(node, node => cleanupDecorators(node));