feat(@angular/cli): add disable/enable aliases for off/on ng analytics command

alan-agius4 · clydin · commit 7ab22ed40d52 · 2022-03-15T16:31:07.000-04:00
`ng analytics enable/disable`better aligns with `ng cache enable/disable` that will be available in the future.
diff --git a/packages/angular/cli/src/commands/analytics/settings/cli.ts b/packages/angular/cli/src/commands/analytics/settings/cli.ts
@@ -42,11 +42,12 @@ abstract class AnalyticsSettingModule
   abstract override run({ global }: Options<AnalyticsCommandArgs>): Promise<void>;
 }
 
-export class AnalyticsOffModule
+export class AnalyticsDisableModule
   extends AnalyticsSettingModule
   implements CommandModuleImplementation<AnalyticsCommandArgs>
 {
-  command = 'off';
+  command = 'disable';
+  aliases = 'off';
   describe = 'Disables analytics gathering and reporting for the user.';
 
   async run({ global }: Options<AnalyticsCommandArgs>): Promise<void> {
@@ -55,11 +56,12 @@ export class AnalyticsOffModule
   }
 }
 
-export class AnalyticsOnModule
+export class AnalyticsEnableModule
   extends AnalyticsSettingModule
   implements CommandModuleImplementation<AnalyticsCommandArgs>
 {
-  command = 'on';
+  command = 'enable';
+  aliases = 'on';
   describe = 'Enables analytics gathering and reporting for the user.';
   async run({ global }: Options<AnalyticsCommandArgs>): Promise<void> {
     setAnalyticsConfig(global, true);

Original file line number	Diff line number	Diff line change
`@@ -42,11 +42,12 @@ abstract class AnalyticsSettingModule`
`42`	`42`	`abstract override run({ global }: Options<AnalyticsCommandArgs>): Promise<void>;`
`43`	`43`	`}`
`44`	`44`
`45`		`-export class AnalyticsOffModule`
	`45`	`+export class AnalyticsDisableModule`
`46`	`46`	`extends AnalyticsSettingModule`
`47`	`47`	`implements CommandModuleImplementation<AnalyticsCommandArgs>`
`48`	`48`	`{`
`49`		`- command = 'off';`
	`49`	`+ command = 'disable';`
	`50`	`+ aliases = 'off';`
`50`	`51`	`describe = 'Disables analytics gathering and reporting for the user.';`
`51`	`52`
`52`	`53`	`async run({ global }: Options<AnalyticsCommandArgs>): Promise<void> {`
`@@ -55,11 +56,12 @@ export class AnalyticsOffModule`
`55`	`56`	`}`
`56`	`57`	`}`
`57`	`58`
`58`		`-export class AnalyticsOnModule`
	`59`	`+export class AnalyticsEnableModule`
`59`	`60`	`extends AnalyticsSettingModule`
`60`	`61`	`implements CommandModuleImplementation<AnalyticsCommandArgs>`
`61`	`62`	`{`
`62`		`- command = 'on';`
	`63`	`+ command = 'enable';`
	`64`	`+ aliases = 'on';`
`63`	`65`	`describe = 'Enables analytics gathering and reporting for the user.';`
`64`	`66`	`async run({ global }: Options<AnalyticsCommandArgs>): Promise<void> {`
`65`	`67`	`setAnalyticsConfig(global, true);`