test: remove redundant killAllProcesses call

`killAllProcesses` is called post test execution there it is not needed to be run after tests.

Author: alan-agius4

tests/legacy-cli/e2e/setup/002-npm-sandbox.ts

@@ -1,6 +1,6 @@
 import { mkdir, writeFile } from 'fs/promises';
 import { join } from 'path';
-import { getGlobalVariable, setGlobalVariable } from '../utils/env';
+import { getGlobalVariable } from '../utils/env';
 
 /**
  * Configure npm to use a unique sandboxed environment.

tests/legacy-cli/e2e/tests/misc/ask-missing-builder.ts

@@ -1,28 +1,24 @@
 import { execAndWaitForOutputToMatch, killAllProcesses } from '../../utils/process';
 
 export default async function () {
-  try {
-    // Execute a command with TTY force enabled and check that the prompt is shown.
-    await execAndWaitForOutputToMatch(
-      'ng',
-      ['deploy'],
-      /Would you like to add a package with "deploy" capabilities/,
-      {
-        ...process.env,
-        NG_FORCE_TTY: '1',
-        NG_CLI_ANALYTICS: 'false',
-      },
-    );
-
-    await killAllProcesses();
-
-    // Execute a command with TTY force enabled and check that the prompt is shown.
-    await execAndWaitForOutputToMatch('ng', ['lint'], /Would you like to add ESLint now/, {
+  // Execute a command with TTY force enabled and check that the prompt is shown.
+  await execAndWaitForOutputToMatch(
+    'ng',
+    ['deploy'],
+    /Would you like to add a package with "deploy" capabilities/,
+    {
       ...process.env,
       NG_FORCE_TTY: '1',
       NG_CLI_ANALYTICS: 'false',
-    });
-  } finally {
-    await killAllProcesses();
-  }
+    },
+  );
+
+  await killAllProcesses();
+
+  // Execute a command with TTY force enabled and check that the prompt is shown.
+  await execAndWaitForOutputToMatch('ng', ['lint'], /Would you like to add ESLint now/, {
+    ...process.env,
+    NG_FORCE_TTY: '1',
+    NG_CLI_ANALYTICS: 'false',
+  });
 }

tests/legacy-cli/e2e/tests/misc/e2e-host.ts

@@ -1,5 +1,5 @@
 import * as os from 'os';
-import { killAllProcesses, ng } from '../../utils/process';
+import { ng } from '../../utils/process';
 import { updateJsonFile } from '../../utils/project';
 
 export default async function () {
@@ -12,18 +12,13 @@ export default async function () {
     }
   }
 
-  try {
-    await updateJsonFile('angular.json', (workspaceJson) => {
-      const appArchitect = workspaceJson.projects['test-project'].architect;
-      appArchitect.serve.options = appArchitect.serve.options || {};
-      appArchitect.serve.options.port = 8888;
-      appArchitect.serve.options.host = host;
-    });
+  await updateJsonFile('angular.json', (workspaceJson) => {
+    const appArchitect = workspaceJson.projects['test-project'].architect;
+    appArchitect.serve.options = appArchitect.serve.options || {};
+    appArchitect.serve.options.port = 8888;
+    appArchitect.serve.options.host = host;
+  });
 
-    await ng('e2e');
-
-    await ng('e2e', '--host', host);
-  } finally {
-    await killAllProcesses();
-  }
+  await ng('e2e');
+  await ng('e2e', '--host', host);
 }

tests/legacy-cli/e2e/tests/misc/proxy-config.ts

@@ -5,8 +5,6 @@ import { writeFile } from '../../utils/fs';
 import fetch from 'node-fetch';
 import { killAllProcesses, ng } from '../../utils/process';
 import { ngServe } from '../../utils/project';
-import { updateJsonFile } from '../../utils/project';
-import { expectToFail } from '../../utils/utils';
 import { AddressInfo } from 'net';
 import * as assert from 'assert';
 

tests/legacy-cli/e2e/tests/misc/title.ts

@@ -1,25 +1,17 @@
-import { execAndWaitForOutputToMatch, execWithEnv, killAllProcesses } from '../../utils/process';
+import { execAndWaitForOutputToMatch, execWithEnv } from '../../utils/process';
 
 export default async function () {
   if (process.platform.startsWith('win')) {
     // "On Windows, process.title affects the console title, but not the name of the process in the task manager."
     // https://stackoverflow.com/questions/44756196/how-to-change-the-node-js-process-name-on-windows-10#comment96259375_44756196
-    return Promise.resolve();
+    return;
   }
 
-  try {
-    await execAndWaitForOutputToMatch(
-      'ng',
-      ['build', '--configuration=development', '--watch'],
-      /./,
-    );
+  await execAndWaitForOutputToMatch('ng', ['build', '--configuration=development', '--watch'], /./);
 
-    const output = await execWithEnv('ps', ['x'], { COLUMNS: '200' });
+  const output = await execWithEnv('ps', ['x'], { COLUMNS: '200' });
 
-    if (!output.stdout.match(/ng build --configuration=development --watch/)) {
-      throw new Error('Title of the process was not properly set.');
-    }
-  } finally {
-    await killAllProcesses();
+  if (!output.stdout.match(/ng build --configuration=development --watch/)) {
+    throw new Error('Title of the process was not properly set.');
   }
 }

tests/legacy-cli/e2e/utils/test_process.ts

@@ -11,9 +11,13 @@ const testFunction: () => Promise<void> | void =
         throw new Error('Invalid test module.');
       };
 
-(async () => Promise.resolve(testFunction()))()
-  .finally(killAllProcesses)
-  .catch((e) => {
+(async () => {
+  try {
+    await testFunction();
+  } catch (e) {
     console.error(e);
     process.exitCode = -1;
-  });
+  } finally {
+    await killAllProcesses();
+  }
+})();