refactor(@angular-devkit/build-optimizer): remove tsickle code from wrap-enums transformer

Angular packages are no longer annotated for Closure Compiler using Tsickle, therefore these checks are now redundant.

Author: alan-agius4

packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.ts

@@ -92,7 +92,7 @@ function visitBlockStatements(
         const name = variableDeclaration.name.text;
 
         if (!initializer) {
-          const iife = findTs2_3EnumIife(name, statements[oIndex + 1]);
+          const iife = findEnumIife(name, statements[oIndex + 1]);
           if (iife) {
             // update IIFE and replace variable statement and old IIFE
             oldStatementsLength = 2;
@@ -104,30 +104,6 @@ function visitBlockStatements(
             // skip IIFE statement
             oIndex++;
           }
-        } else if (ts.isObjectLiteralExpression(initializer)) {
-          // tsickle es2015 enums first statement is an export declaration
-          const isPotentialEnumExport = ts.isExportDeclaration(statements[oIndex + 1]);
-          if (isPotentialEnumExport) {
-            // skip the export
-            oIndex++;
-          }
-
-          const enumStatements = findStatements(name, statements, oIndex, 1);
-          if (!enumStatements) {
-            continue;
-          }
-
-          // create wrapper and replace variable statement and enum member statements
-          oldStatementsLength = enumStatements.length + (isPotentialEnumExport ? 2 : 1);
-          newStatement = createWrappedEnum(
-            name,
-            currentStatement,
-            enumStatements,
-            initializer,
-            isPotentialEnumExport,
-          );
-          // skip enum member declarations
-          oIndex += enumStatements.length;
         } else if (
           ts.isClassExpression(initializer)
           || (
@@ -191,7 +167,7 @@ function visitBlockStatements(
 }
 
 // TS 2.3 enums have statements that are inside a IIFE.
-function findTs2_3EnumIife(
+function findEnumIife(
   name: string,
   statement: ts.Statement,
 ): [ts.CallExpression, ts.Expression | undefined] | null {

packages/angular_devkit/build_optimizer/src/transforms/wrap-enums_spec.ts

@@ -448,28 +448,6 @@ describe('wrap enums and classes transformer', () => {
   });
 
   describe('wrap enums', () => {
-    it('wraps ts 2.2 enums in IIFE', () => {
-      const input = tags.stripIndent`
-        export var ChangeDetectionStrategy = {};
-        ChangeDetectionStrategy.OnPush = 0;
-        ChangeDetectionStrategy.Default = 1;
-        ChangeDetectionStrategy[ChangeDetectionStrategy.OnPush] = "OnPush";
-        ChangeDetectionStrategy[ChangeDetectionStrategy.Default] = "Default";
-      `;
-      const output = tags.stripIndent`
-        export var ChangeDetectionStrategy = /*@__PURE__*/ (function () {
-          var ChangeDetectionStrategy = {};
-          ChangeDetectionStrategy.OnPush = 0;
-          ChangeDetectionStrategy.Default = 1;
-          ChangeDetectionStrategy[ChangeDetectionStrategy.OnPush] = "OnPush";
-          ChangeDetectionStrategy[ChangeDetectionStrategy.Default] = "Default";
-          return ChangeDetectionStrategy;
-        }());
-      `;
-
-      expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
-    });
-
     it('should not wrap enum like object literal declarations', () => {
       const input = tags.stripIndent`
         const RendererStyleFlags3 = {
@@ -486,63 +464,6 @@ describe('wrap enums and classes transformer', () => {
       expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
     });
 
-    it('wraps ES2015 tsickle enums in IIFE', () => {
-      const input = tags.stripIndent`
-        const ChangeDetectionStrategy = {
-            OnPush: 0,
-            Default: 1,
-        };
-        export { ChangeDetectionStrategy };
-        ChangeDetectionStrategy[ChangeDetectionStrategy.OnPush] = 'OnPush';
-        ChangeDetectionStrategy[ChangeDetectionStrategy.Default] = 'Default';
-      `;
-
-      const output = tags.stripIndent`
-        export const ChangeDetectionStrategy = /*@__PURE__*/ (function () {
-            var ChangeDetectionStrategy = { OnPush: 0, Default: 1, };
-
-            ChangeDetectionStrategy[ChangeDetectionStrategy.OnPush] = 'OnPush';
-            ChangeDetectionStrategy[ChangeDetectionStrategy.Default] = 'Default';
-            return ChangeDetectionStrategy;
-        }());
-      `;
-
-      expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
-    });
-
-    it('wraps only ES2015 tsickle enums in IIFE', () => {
-      const input = tags.stripIndent`
-        const RendererStyleFlags3 = {
-            Important: 1,
-            DashCase: 2,
-        };
-        export { RendererStyleFlags3 };
-        RendererStyleFlags3[RendererStyleFlags3.Important] = 'Important';
-        RendererStyleFlags3[RendererStyleFlags3.DashCase] = 'DashCase';
-
-        export const domRendererFactory3 = {
-            createRenderer: (hostElement, rendererType) => { return document; }
-        };
-
-        export const unusedValueExportToPlacateAjd = 1;
-      `;
-      const output = tags.stripIndent`
-        export const RendererStyleFlags3 = /*@__PURE__*/ (function () {
-          var RendererStyleFlags3 = { Important: 1, DashCase: 2, };
-          RendererStyleFlags3[RendererStyleFlags3.Important] = 'Important';
-          RendererStyleFlags3[RendererStyleFlags3.DashCase] = 'DashCase';
-          return RendererStyleFlags3;
-        }());
-
-        export const domRendererFactory3 = {
-          createRenderer: (hostElement, rendererType) => { return document; }
-        };
-
-        export const unusedValueExportToPlacateAjd = 1;
-      `;
-
-      expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
-    });
 
     it('wraps ts >2.3 enums in IIFE', () => {
       const input = tags.stripIndent`
@@ -662,39 +583,6 @@ describe('wrap enums and classes transformer', () => {
       expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
     });
 
-    it('wraps tsickle enums in IIFE', () => {
-      const input = tags.stripIndent`
-        /** @enum {number} */
-        var FormatWidth = {
-          Short: 0,
-          Medium: 1,
-          Long: 2,
-          Full: 3,
-        };
-        FormatWidth[FormatWidth.Short] = "Short";
-        FormatWidth[FormatWidth.Medium] = "Medium";
-        FormatWidth[FormatWidth.Long] = "Long";
-        FormatWidth[FormatWidth.Full] = "Full";
-      `;
-      const output = tags.stripIndent`
-        /** @enum {number} */ var FormatWidth = /*@__PURE__*/ (function () {
-          var FormatWidth = {
-            Short: 0,
-            Medium: 1,
-            Long: 2,
-            Full: 3,
-          };
-          FormatWidth[FormatWidth.Short] = "Short";
-          FormatWidth[FormatWidth.Medium] = "Medium";
-          FormatWidth[FormatWidth.Long] = "Long";
-          FormatWidth[FormatWidth.Full] = "Full";
-          return FormatWidth;
-        }());
-      `;
-
-      expect(tags.oneLine`${transform(input)}`).toEqual(tags.oneLine`${output}`);
-    });
-
     it('wraps enums with multi-line comments in IIFE', () => {
       const input = tags.stripIndent`
         /**