Skip to content

Commit 5fd5cf0

Browse files
committed
test: rename npm E2E suite to webpack
The current `npm` E2E test suite is actually the browser builder (Webpack-based) tests. The name has now been updated to better reflect the test behavior. (cherry picked from commit a53e666)
1 parent d76a51d commit 5fd5cf0

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
matrix:
8181
os: [ubuntu-latest]
8282
node: [20, 22, 24]
83-
subset: [npm, esbuild]
83+
subset: [esbuild, webpack]
8484
shard: [0, 1, 2, 3, 4, 5]
8585
runs-on: ${{ matrix.os }}
8686
steps:
@@ -134,7 +134,7 @@ jobs:
134134
matrix:
135135
os: [windows-2025]
136136
node: [22]
137-
subset: [npm, esbuild]
137+
subset: [esbuild, webpack]
138138
shard: [0, 1, 2, 3, 4, 5]
139139
runs-on: ${{ matrix.os }}
140140
steps:
@@ -187,7 +187,7 @@ jobs:
187187
matrix:
188188
os: [ubuntu-latest]
189189
node: [22]
190-
subset: [npm, esbuild]
190+
subset: [esbuild, webpack]
191191
shard: [0, 1, 2, 3, 4, 5]
192192
runs-on: ${{ matrix.os }}
193193
steps:

.github/workflows/pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
matrix:
111111
os: [ubuntu-latest]
112112
node: [22]
113-
subset: [npm, esbuild]
113+
subset: [esbuild, webpack]
114114
shard: [0, 1, 2, 3, 4, 5]
115115
runs-on: ${{ matrix.os }}
116116
steps:
@@ -203,7 +203,7 @@ jobs:
203203
matrix:
204204
os: [ubuntu-latest]
205205
node: [22]
206-
subset: [npm, esbuild]
206+
subset: [esbuild, webpack]
207207
shard: [0, 1, 2, 3, 4, 5]
208208
runs-on: ${{ matrix.os }}
209209
steps:

tests/legacy-cli/e2e.bzl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,14 @@ def e2e_suites(name, runner, data):
8383
# Default target meant to be run manually for debugging, customizing test cli via bazel
8484
_e2e_tests(name + "_" + toolchain_name, runner, data = data, toolchain = toolchain, tags = ["manual"])
8585

86-
_e2e_suite(name, runner, "npm", data, toolchain_name, toolchain)
86+
# Main test suites
87+
_e2e_suite(name, runner, "webpack", data, toolchain_name, toolchain)
88+
_e2e_suite(name, runner, "esbuild", data, toolchain_name, toolchain)
89+
90+
# Package manager subsets
8791
_e2e_suite(name, runner, "bun", data, toolchain_name, toolchain)
8892
_e2e_suite(name, runner, "pnpm", data, toolchain_name, toolchain)
8993
_e2e_suite(name, runner, "yarn", data, toolchain_name, toolchain)
90-
_e2e_suite(name, runner, "esbuild", data, toolchain_name, toolchain)
9194

9295
# Saucelabs tests are only run on the default toolchain
9396
_e2e_suite(name, runner, "saucelabs", data)
@@ -162,7 +165,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
162165
args.append("--esbuild")
163166
tests = BROWSER_TESTS
164167
ignore = None
165-
elif type == "npm":
168+
elif type == "webpack":
166169
tests = None
167170
ignore = BROWSER_TESTS + WEBPACK_IGNORE_TESTS
168171

0 commit comments

Comments
 (0)