feat: permissions guards actions by menoude-aneo · Pull Request #1355 · aneoconsulting/ArmoniK.Admin.GUI

menoude-aneo · 2025-11-17T13:27:44Z

No description provided.

github-actions · 2025-11-17T13:29:51Z

Lines	Statements	Branches	Functions
	96.97% (5489/5660)	87.41% (1042/1192)	95.06% (1427/1501)

JUnit

Tests	Skipped	Failures	Errors	Time
2022	0 💤	0 ❌	0 🔥	1m 27s ⏱️

Files coverage (96%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	96.97	87.41	95.06	96.99
src/app/applications	100	100	100	100
index.component.html	100	100	100	100
index.component.ts	100	100	100	100
src/app/applications/components	100	100	100	100
table.component.html	100	100	100	100
table.component.ts	100	100	100	100
src/app/applications/services	100	100	100	100
applications-data.service.ts	100	100	100	100
applications-filters.service.ts	100	100	100	100
applications-grpc.service.ts	100	100	100	100
applications-index.service.ts	100	100	100	100
src/app/components	98.3	87.09	98.83	98.16
auto-complete.component.html	100	100	100	100
auto-complete.component.ts	100	100	100	100
auto-refresh-button.component.html	100	100	100	100
auto-refresh-button.component.ts	100	100	100	100
auto-refresh-dialog.component.html	100	100	100	100
auto-refresh-dialog.component.ts	100	100	100	100
columns-button.component.html	100	100	100	100
columns-button.component.ts	100	100	100	100
count-tasks-by-status.component.html	100	100	100	100
count-tasks-by-status.component.ts	90	62.5	100	89.74	70–71, 82–83
icon-picker-dialog.component.html	100	100	100	100
icon-picker-dialog.component.ts	100	100	100	100
inspect-list.component.html	100	100	100	100
inspect-list.component.ts	100	100	100	100
inspection-header.component.html	100	100	100	100
inspection-header.component.ts	100	66.66	100	100	55
inspection-toolbar.component.html	100	100	100	100
inspection-toolbar.component.ts	100	100	100	100
manage-custom-dialog.component.html	100	100	100	100
manage-custom-dialog.component.ts	100	100	100	100
page-header.component.html	100	100	100	100
page-header.component.ts	100	100	100	100
page-section-header.component.html	100	100	100	100
page-section-header.component.ts	100	100	100	100
refresh-button.component.html	100	100	100	100
refresh-button.component.ts	100	100	100	100
share-url.component.html	100	100	100	100
share-url.component.ts	100	100	100	100
show-action-area.component.html	100	100	100	100
show-action-area.component.ts	100	100	100	100
show-actions.component.html	100	100	100	100
show-actions.component.ts	100	100	100	100
show-card-content.component.html	100	100	100	100
show-card-content.component.ts	100	100	100	100
show-card.component.html	100	100	100	100
show-card.component.ts	100	100	100	100
show-page.component.html	100	100	100	100
show-page.component.ts	100	100	100	100
spinner.component.html	100	100	100	100
spinner.component.ts	100	100	100	100
status-chip.component.html	100	100	100	100
status-chip.component.ts	50	0	0	46.15	20–30
status-color-picker.component.html	100	100	100	100
status-color-picker.component.ts	100	100	100	100
status-color-picker.dialog.component.html	100	100	100	100
status-color-picker.dialog.component.ts	100	100	100	100
table-actions-toolbar.component.html	100	100	100	100
table-actions-toolbar.component.ts	100	100	100	100
table-container.component.html	100	100	100	100
table-container.component.ts	100	100	100	100
table-dashboard-actions-toolbar.component.html	100	100	100	100
table-dashboard-actions-toolbar.component.ts	100	100	100	100
table-index-actions-toolbar.component.html	100	100	100	100
table-index-actions-toolbar.component.ts	100	100	100	100
view-tasks-by-status.component.html	100	100	100	100
view-tasks-by-status.component.ts	100	100	100	100
src/app/components/dialogs/columns-modify-dialog	100	100	100	100
columns-modify-dialog.component.html	100	100	100	100
columns-modify-dialog.component.ts	100	100	100	100
src/app/components/dialogs/columns-modify-dialog/components	100	100	100	100
columns-modify-area.component.html	100	100	100	100
columns-modify-area.component.ts	100	100	100	100
src/app/components/filters	100	100	100	100
filters-chips.component.html	100	100	100	100
filters-chips.component.ts	100	100	100	100
filters-dialog-and.component.html	100	100	100	100
filters-dialog-and.component.ts	100	100	100	100
filters-dialog-filter-field.component.html	100	100	100	100
filters-dialog-filter-field.component.ts	100	100	100	100
filters-dialog-input.component.html	100	100	100	100
filters-dialog-input.component.ts	100	100	100	100
filters-dialog-or.component.html	100	100	100	100
filters-dialog-or.component.ts	100	100	100	100
filters-dialog.component.html	100	100	100	100
filters-dialog.component.ts	100	100	100	100
filters-toolbar.component.html	100	100	100	100
filters-toolbar.component.ts	100	100	100	100
src/app/components/graph	99.4	100	97.43	99.36
graph-legend.component.html	100	100	100	100
graph-legend.component.ts	100	100	100	100
graph.component.html	100	100	100	100
graph.component.ts	99.31	100	97.14	99.28	123
src/app/components/inspection	98.66	95.23	95.91	98.6
byte-array.component.html	100	100	100	100
byte-array.component.ts	95.12	66.66	83.33	95	97–98
field-content.component.html	100	100	100	100
field-content.component.ts	100	100	100	100
inspection-card.component.html	100	100	100	100
inspection-card.component.ts	100	100	100	100
inspection-json.component.html	100	100	100	100
inspection-json.component.ts	100	100	100	100
inspection-list-grid.component.html	100	100	100	100
inspection-list-grid.component.ts	100	100	100	100
inspection-object.component.html	100	100	100	100
inspection-object.component.ts	96.15	100	91.66	96	70
inspection.component.html	100	100	100	100
inspection.component.ts	100	100	100	100
json.component.html	100	100	100	100
json.component.ts	100	100	100	100
message.component.html	100	100	100	100
message.component.ts	100	100	100	100
src/app/components/navigation	100	100	100	100
change-language-button.component.html	100	100	100	100
change-language-button.component.ts	100	100	100	100
navigation.component.html	100	100	100	100
navigation.component.ts	100	100	100	100
theme-selector.component.html	100	100	100	100
theme-selector.component.ts	100	100	100	100
src/app/components/navigation/external-services	100	100	100	100
external-services.component.html	100	100	100	100
external-services.component.ts	100	100	100	100
form-external-service.component.html	100	100	100	100
form-external-service.component.ts	100	100	100	100
manage-external-services-dialog.component.html	100	100	100	100
manage-external-services-dialog.component.ts	100	100	100	100
src/app/components/navigation/scheme-switcher	100	100	100	100
scheme-switcher.component.html	100	100	100	100
scheme-switcher.component.ts	100	100	100	100
src/app/components/navigation/version-menu	100	100	100	100
repository-version.component.html	100	100	100	100
repository-version.component.ts	100	100	100	100
versions-menu.component.html	100	100	100	100
versions-menu.component.ts	100	100	100	100
src/app/components/statuses	100	100	100	100
add-statuses-group-dialog.component.html	100	100	100	100
add-statuses-group-dialog.component.ts	100	100	100	100
edit-status-group-dialog.component.html	100	100	100	100
edit-status-group-dialog.component.ts	100	100	100	100
form-statuses-group.component.html	100	100	100	100
form-statuses-group.component.ts	100	100	100	100
manage-groups-dialog.component.html	100	100	100	100
manage-groups-dialog.component.ts	100	100	100	100
src/app/components/table	99.61	100	98.71	99.58
table-actions.component.html	100	100	100	100
table-actions.component.ts	100	100	100	100
table-cell.component.html	100	100	100	100
table-cell.component.ts	98.36	100	95.23	98.33	115
table-column-header.component.html	100	100	100	100
table-column-header.component.ts	100	100	100	100
table-inspect-message-dialog.component.html	100	100	100	100
table-inspect-message-dialog.component.ts	100	100	100	100
table-inspect-message.component.html	100	100	100	100
table-inspect-message.component.ts	100	100	100	100
table-inspect-object-dialog.component.html	100	100	100	100
table-inspect-object-dialog.component.ts	100	100	100	100
table-inspect-object.component.html	100	100	100	100
table-inspect-object.component.ts	100	100	100	100
table.component.html	100	100	100	100
table.component.ts	100	100	100	100
src/app/components/table/cells	95	71.42	83.33	94.87
byte-array-cell.component.html	100	100	100	100
byte-array-cell.component.ts	94.87	71.42	83.33	94.73	97–98
src/app/dashboard	92.55	58.33	65	92.39
index.component.html	100	100	100	100
index.component.ts	92.47	58.33	65	92.3	226–250
src/app/dashboard/components	93.33	71.42	91.48	92.94
add-line-dialog.component.html	100	100	100	100
add-line-dialog.component.ts	79.31	53.33	73.33	78.94	50, 93, 107, 114–133
edit-name-line-dialog.component.html	100	100	100	100
edit-name-line-dialog.component.ts	100	100	100	100
reorganize-lines-dialog.component.html	100	100	100	100
reorganize-lines-dialog.component.ts	100	100	100	100
split-lines-dialog.component.html	100	100	100	100
split-lines-dialog.component.ts	100	100	100	100
statuses-group-card.component.html	100	100	100	100
statuses-group-card.component.ts	100	100	100	100
src/app/dashboard/components/lines	98.51	62.5	97.91	98.43
applications-line.component.html	100	100	100	100
applications-line.component.ts	100	100	100	100
partitions-line.component.html	100	100	100	100
partitions-line.component.ts	100	100	100	100
results-line.component.html	100	100	100	100
results-line.component.ts	100	100	100	100
sessions-line.component.html	100	100	100	100
sessions-line.component.ts	94.44	0	80	94.11	68–69
task-by-status-line.component.html	100	100	100	100
task-by-status-line.component.ts	97.84	81.81	100	97.77	102–103
tasks-line.component.html	100	100	100	100
tasks-line.component.ts	100	100	100	100
src/app/dashboard/services	100	100	100	100
dashboard-index.service.ts	100	100	100	100
dashboard-storage.service.ts	100	100	100	100
src/app/healthcheck	100	100	100	100
healthcheck.component.html	100	100	100	100
healthcheck.component.ts	100	100	100	100
src/app/healthcheck/services	100	100	100	100
healthcheck-grpc.service.ts	100	100	100	100
src/app/partitions	100	100	100	100
index.component.html	100	100	100	100
index.component.ts	100	100	100	100
show.component.html	100	100	100	100
show.component.ts	100	100	100	100
src/app/partitions/components	100	100	100	100
table.component.html	100	100	100	100
table.component.ts	100	100	100	100
src/app/partitions/services	100	100	100	100
partitions-data.service.ts	100	100	100	100
partitions-filters.service.ts	100	100	100	100
partitions-grpc.service.ts	100	100	100	100
partitions-index.service.ts	100	100	100	100
partitions-inspection.service.ts	100	100	100	100
src/app/pipes	100	100	100	100
custom-column.pipe.ts	100	100	100	100
duration.pipe.ts	100	100	100	100
empty-cell.pipe.ts	100	100	100	100
pretty.pipe.ts	100	100	100	100
src/app/profile	100	100	100	100
index.component.html	100	100	100	100
index.component.ts	100	100	100	100
types.ts	100	100	100	100
src/app/profile/guards	100	100	100	100
user-connected.guard.ts	100	100	100	100
src/app/results	75.53	25	60.71	75.75
index.component.html	100	100	100	100
index.component.ts	100	100	100	100
show.component.html	100	100	100	100
show.component.ts	64.58	25	54.16	64.83	83–124, 193–209
src/app/results/components	55.55	22.22	30.55	57.25
table.component.html	100	100	100	100
table.component.ts	55.22	22.22	30.55	56.91	64–110, 124–160, 233–274
src/app/results/services	100	94.73	100	100
results-data.service.ts	100	100	100	100
results-filters.service.ts	100	100	100	100
results-grpc.service.ts	100	100	100	100
results-index.service.ts	100	88.88	100	100	89
results-inspection.service.ts	100	100	100	100
results-statuses.service.ts	100	100	100	100
src/app/services	98.27	96.37	96.53	98.07
auto-refresh.service.ts	100	100	100	100
byte-array.service.ts	100	100	100	100
cache.service.ts	100	100	100	100
default-config.service.ts	97.91	100	95	97.82	366
environment.service.ts	100	100	100	100
filters-cache.service.ts	100	100	100	100
filters.service.ts	100	100	100	100
graph-data.service.ts	100	100	100	100
grpc-build-request.service.ts	100	100	100	100
grpc-events.service.ts	100	100	100	100
grpc-sort-field.service.ts	100	100	100	100
icons.service.ts	100	100	100	100
navigation.service.ts	95.34	90	94.11	94.87	79–80
notification.service.ts	100	100	100	100
query-params.service.ts	100	100	100	100
share-url.service.ts	100	100	100	100
storage.service.ts	100	100	100	100
table-storage.service.ts	100	100	100	100
table-url.service.ts	100	100	100	100
table.service.ts	100	100	100	100
tasks-by-status.service.ts	100	100	100	100
theme.service.ts	100	100	100	100
user-grpc.service.ts	100	100	100	100
user.service.ts	36.36	0	0	22.22	14–36
utils.service.ts	100	100	100	100
versions-grpc.service.ts	100	100	100	100
versions.service.ts	100	100	100	100
src/app/sessions	95.72	65	91.22	95.57
graph.component.html	100	100	100	100
graph.component.ts	100	100	100	100
index.component.html	100	100	100	100
index.component.ts	96.42	33.33	87.5	96.29	98–99
show.component.html	100	100	100	100
show.component.ts	94.87	67.56	90.9	94.73	109–110, 129–140
src/app/sessions/components	96.47	61.53	92.85	97.26
table.component.html	100	100	100	100
table.component.ts	96.42	61.53	92.85	97.22	42–43
src/app/sessions/services	100	100	100	100
sessions-data.service.ts	100	100	100	100
sessions-filters.service.ts	100	100	100	100
sessions-grpc.service.ts	100	100	100	100
sessions-index.service.ts	100	100	100	100
sessions-inspection.service.ts	100	100	100	100
sessions-statuses.service.ts	100	100	100	100
src/app/settings	100	100	100	100
index.component.html	100	100	100	100
index.component.ts	100	100	100	100
src/app/settings/component	100	100	100	100
clear-all-dialog.component.html	100	100	100	100
clear-all-dialog.component.ts	100	100	100	100
src/app/tasks	96.29	47.05	92.3	96.15
index.component.html	100	100	100	100
index.component.ts	95.77	33.33	91.66	95.65	101–102, 107
show.component.html	100	100	100	100
show.component.ts	96.77	62.5	92.85	96.61	89–90
src/app/tasks/components	100	93.75	100	100
manage-view-in-logs-dialog.component.html	100	100	100	100
manage-view-in-logs-dialog.component.ts	100	100	100	100
table.component.html	100	100	100	100
table.component.ts	100	92.85	100	100	135
src/app/tasks/services	96.12	94	95.74	96.5
tasks-data.service.ts	100	100	100	100
tasks-filters.service.ts	100	100	100	100
tasks-grpc.service.ts	100	100	100	100
tasks-index.service.ts	85.36	76.92	88.23	86.84	254–261
tasks-inspection.service.ts	100	100	100	100
tasks-statuses.service.ts	100	100	100	100
src/app/types	100	100	100	100
navigation.ts	100	100	100	100
status.ts	100	100	100	100
themes.ts	100	100	100	100
src/app/types/components	99.32	100	98.07	100
dashboard-line-table.ts	99.13	100	97.36	100
index.ts	99.05	100	97.29	100
show.ts	100	100	100	100
table.ts	100	100	100	100
src/app/types/services	100	100	100	100
data-filter.service.ts	100	100	100	100
grpcService.ts	100	100	100	100
inspectionService.ts	100	100	100	100
table-data.service.ts	100	100	100	100
test	100	100	100	100
d3.js	100	100	100	100
force-graph.js	100	100	100	100

sonarqubecloud · 2025-11-19T11:05:01Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fdewas-aneo · 2025-11-21T10:19:09Z

          throw new Error('No user');
        }
        userService.user = data.user;
+        navigationService.refreshSidebar();


I don't think you have to do this, since it already initialize the sidebar on its construction (when the service is provided for the first time)

fdewas-aneo · 2025-11-21T10:24:43Z

+export class ApplicationsAccessGuard implements CanActivate {
+  private readonly userService = inject(UserService);
+  private readonly router = inject(Router);
+
+  canActivate(): boolean {
+    const permissions = this.userService.user?.permissions ?? [];
+    const hasPermission = permissions.includes('Applications:ListApplications');
+
+    if (!hasPermission) {
+      this.router.navigate(['/dashboard']);
+      return false;
+    }
+
+    return true;
+  }


Could you create an abstract class with just an abstract member permission, which would represent in this case "Applications:ListApplications".

We would have in the end:

export class ApplicationsAccessGuard extends AbstractAcessGuard { permission = 'Applications:ListApplications'; }

fdewas-aneo · 2025-11-21T10:26:39Z

+        { provide: UserService, useValue: mockUserService },
+        { provide: UserService, useValue: mockUserService }
      ]
    }).inject(CountTasksByStatusComponent);


Could you provide a test for:

hasCountPermission

The changes you've made in the ngOnInit ?

The changes you've made in the initRefresh ?

fdewas-aneo · 2025-11-21T10:40:15Z

+  get hasDownloadPermission(): boolean {
+    const permissions = this.userService.user?.permissions ?? [];
+    return permissions.includes('Results:DownloadResultData');
+  }


This is not generic enough. if we have another download action, we will have to add it there, and it will not be easy to do it in every component.
If you look inside the inspection-object component, you will see that we use an object called field. I think you should update the type Field by adding a permission (which could be a string or an array of string containing "result:downloadResultdata").
Then you could add the input permissions to the component, pass it via inspection-object, and replace the string with this input.
Finally, you will just have to add the permission inside the various ...-inspection.service.ts.

fdewas-aneo · 2025-11-21T10:41:47Z

        { provide: NotificationService, useValue: mockNotificationService },
+        { provide: UserService, useValue: mockUserService },
      ]
    }).inject(ByteArrayComponent);


Please provide test for hasDownloadPermission

fdewas-aneo · 2025-11-21T16:13:02Z

+          <button mat-flat-button 
+                  [color]="hasCancelTaskPermission ? 'accent' : ''" 
+                  (click)="onCancelTasksSelection()" 
+                  [disabled]="!selection.length || !hasCancelTaskPermission"
+                  [class.disabled-button]="!hasCancelTaskPermission">


No need to change color or add disabled-button class.

fdewas-aneo · 2025-11-21T16:13:32Z

+  get hasListTasksPermission(): boolean {
+    const permissions = this.userService.user?.permissions ?? [];
+    return permissions.includes('Tasks:ListTasks') || permissions.includes('Tasks:ListTasksDetailed') || permissions.includes('Tasks:GetResultId');
+  }
+
+  get hasCancelTaskPermission(): boolean {
+    const permissions = this.userService.user?.permissions ?? [];
+    return permissions.includes('Tasks:CancelTask');
+  }


Inside a service

fdewas-aneo · 2025-11-21T16:15:40Z

+  private readonly detailedColumns: string[] = [
+    'acquiredAt', 'endedAt', 'initialTaskId', 'ownerPodId', 'podHostname', 
+    'podTtl', 'receivedAt', 'startedAt', 'statusMessage', 'submittedAt',
+    'creationToEndDuration', 'processingToEndDuration', 'receivedToEndDuration',
+    'countDataDependencies', 'countExpectedOutputIds', 'countParentTaskIds', 
+    'countRetryOfIds', 'error', 'fetchedAt', 'processedAt', 'payloadId'
+  ];
+
+  get availableTableColumns(): TableColumn<TaskSummary, TaskOptions>[] {
+    const permissions = this.userService.user?.permissions ?? [];
+    const hasDetailedPermission = permissions.includes('Tasks:ListTasksDetailed');
+
+    if (hasDetailedPermission) {
+      return this._allTableColumns;
+    }
+
+    return this._allTableColumns.filter(column => !this.detailedColumns.includes(column.key as string));
+  }


TaskDetailed is a weirdly specific thing for armonik, but it is overall just a task. No need to make such a specific implementation to check it. ListTask is the same.

fdewas-aneo · 2025-11-21T16:16:00Z

+    <button mat-flat-button 
+            [color]="canCancel ? 'accent' : ''" 
+            (click)="cancel()" 
+            [disabled]="!canCancel"
+            [class.disabled-button]="!canCancel">


No need to change code or add disabled-button

fdewas-aneo · 2025-11-21T16:16:18Z

+  get hasCancelTaskPermission(): boolean {
+    const permissions = this.userService.user?.permissions ?? [];
+    return permissions.includes('Tasks:CancelTask');
+  }
+


In a service

feat: Add guard for download result actions

3624922

menoude-aneo self-assigned this Nov 17, 2025

menoude-aneo changed the title ~~Feat/add permissions guards actions~~ feat: permissions guards actions Nov 17, 2025

feat: add permissions guards

0045a4e

menoude-aneo force-pushed the feat/add-permissions-guards-actions branch from fdf414b to 0045a4e Compare November 19, 2025 11:04

fdewas-aneo requested changes Nov 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: permissions guards actions#1355

feat: permissions guards actions#1355
menoude-aneo wants to merge 2 commits into
mainfrom
feat/add-permissions-guards-actions

menoude-aneo commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Nov 19, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

fdewas-aneo Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

menoude-aneo commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JUnit

Uh oh!

sonarqubecloud Bot commented Nov 19, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Nov 17, 2025 •

edited

Loading