Summary
Remove TODO(#231) crate-level #![allow] exemptions from non-chain infrastructure crates.
Scope
| Crate |
Violations |
Pattern |
parser_app |
~12 |
CLI arg parsing expect(), signal handlers, borsh serialization |
parser_grpc_server |
~2 |
Ephemeral key load, reflection service init |
parser_gateway |
~1 |
SIGTERM handler registration |
metrics |
~5 lib, ~8 test |
Metric static expect(), server bind, test setup |
integration |
~27 |
Test infrastructure — process spawning, client setup |
examples |
~5 |
Demo binary |
generated |
3 |
Auto-generated protobuf code — may need codegen template changes |
Most violations are expect() in startup/init code where crashing is arguably acceptable (can't serve if you can't bind a port). These can either be converted to proper error propagation or given per-line #[allow] with a justification comment.
Depends on
Summary
Remove
TODO(#231)crate-level#![allow]exemptions from non-chain infrastructure crates.Scope
parser_appexpect(), signal handlers, borsh serializationparser_grpc_serverparser_gatewaymetricsexpect(), server bind, test setupintegrationexamplesgeneratedMost violations are
expect()in startup/init code where crashing is arguably acceptable (can't serve if you can't bind a port). These can either be converted to proper error propagation or given per-line#[allow]with a justification comment.Depends on