Remove checks for >= python 3.8

Author: analog-cbarber

src/mkdocstrings_handlers/python_xref/crossref.py

@@ -1,4 +1,4 @@
-#  Copyright (c) 2022-2023.   Analog Devices Inc.
+#  Copyright (c) 2022-2024.   Analog Devices Inc.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -28,9 +28,6 @@
 
 logger = get_logger(__name__)
 
-# line numbers from griffe are not reliable before python 3.8; this may eventually be fixed...
-_supports_linenums = sys.version_info >= (3,8)
-
 def _re_or(*exps: str) -> str:
     """Construct an "or" regular expression from a sequence of regular expressions.
 
@@ -309,10 +306,9 @@ def _error(self, msg: str, just_warn: bool = False) -> None:
             prefix = f"file://{parent.filepath}:"
             line = doc.lineno
             if line is not None:  # pragma: no branch
-                if _supports_linenums:  # pragma: no branch
-                    # Add line offset to match in docstring. This can still be
-                    # short if the doc string has leading newlines.
-                    line += doc.value.count("\n", 0, self._cur_offset)
+                # Add line offset to match in docstring. This can still be
+                # short if the doc string has leading newlines.
+                line += doc.value.count("\n", 0, self._cur_offset)
                 prefix += f"{line}:"
                 # It would be nice to add the column as well, but we cannot determine
                 # that without knowing how much the doc string was unindented.

tests/test_crossref.py

@@ -1,4 +1,4 @@
-#  Copyright (c) 2022.   Analog Devices Inc.
+#  Copyright (c) 2022-2024.   Analog Devices Inc.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -47,8 +47,6 @@ def test_RelativeCrossrefProcessor(caplog: pytest.LogCaptureFixture, monkeypatch
     meth1 = Function(name="meth1", parent=cls1)
     cls1.members.update(meth1=meth1)
 
-    monkeypatch.setattr(mkdocstrings_handlers.python_xref.crossref, '_supports_linenums', True)
-
     def assert_sub(parent: Object, title: str, ref: str,
                    expected: str = "",
                    *,

tests/test_integration.py

@@ -1,4 +1,4 @@
-#  Copyright (c) 2022.   Analog Devices Inc.
+#  Copyright (c) 2022-2024.   Analog Devices Inc.
 #
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -79,11 +79,10 @@ def test_integration(tmpdir: PathLike) -> None:
     if os.path.sep == '/':
         assert m[1] == str(bar_src_file)
     assert m[3] == 'myproj.bar.bad'
-    if sys.version_info >= (3,8):
-        # Source location not accurate in python 3.7
-        bad_line = int(m[2])
-        bar_lines = bar_src_file.read_text().splitlines()
-        assert '[bad]' in bar_lines[bad_line - 1]
+    # Source location not accurate in python 3.7
+    bad_line = int(m[2])
+    bar_lines = bar_src_file.read_text().splitlines()
+    assert '[bad]' in bar_lines[bad_line - 1]
 
     bar_html = site_dir.joinpath('bar', 'index.html').read_text()
     bar_bs = bs4.BeautifulSoup(bar_html, 'html.parser')