Remove attribution reporting api from ads

Author: powerivq

extensions/amp-a4a/0.1/amp-a4a.js

@@ -28,7 +28,6 @@ import {triggerAnalyticsEvent} from '#utils/analytics';
 import {DomTransformStream} from '#utils/dom-transform-stream';
 import {listenOnce} from '#utils/event-helper';
 import {dev, devAssert, logHashParam, user, userAssert} from '#utils/log';
-import {isAttributionReportingAllowed} from '#utils/privacy-sandbox-utils';
 
 import {canSetCookie, getCookie} from 'src/cookies';
 
@@ -2071,11 +2070,7 @@ export class AmpA4A extends AMP.BaseElement {
     // Block synchronous XHR in ad. These are very rare, but super bad for UX
     // as they block the UI thread for the arbitrary amount of time until the
     // request completes.
-    let featurePolicies = "sync-xhr 'none';";
-
-    if (isAttributionReportingAllowed(this.win.document)) {
-      featurePolicies += "attribution-reporting 'src';";
-    }
+    const featurePolicies = "sync-xhr 'none';";
 
     mergedAttributes['allow'] = featurePolicies;
 

extensions/amp-a4a/0.1/secure-frame.js

@@ -1,7 +1,5 @@
 import {createElementWithAttributes, escapeHtml} from '#core/dom';
 
-import {isAttributionReportingAllowed} from '#utils/privacy-sandbox-utils';
-
 import {getFieSafeScriptSrcs} from '../../../src/friendly-iframe-embed';
 
 // If making changes also change ALLOWED_FONT_REGEX in head-validation.js
@@ -85,9 +83,5 @@ export function createSecureFrame(win, title, height, width) {
     })
   );
 
-  if (isAttributionReportingAllowed(document)) {
-    iframe.setAttribute('allow', `attribution-reporting 'src'`);
-  }
-
   return iframe;
 }

extensions/amp-a4a/0.1/test/test-amp-a4a.js

@@ -20,7 +20,6 @@ import {installRealTimeConfigServiceForDoc} from '#service/real-time-config/real
 
 import * as analytics from '#utils/analytics';
 import {dev, user} from '#utils/log';
-import * as privacySandboxUtils from '#utils/privacy-sandbox-utils';
 
 import {macroTask} from '#testing/helpers';
 import {createIframePromise} from '#testing/iframe';
@@ -921,34 +920,6 @@ describes.realWin('amp-a4a', {amp: true}, (env) => {
         verifyCachedContentIframeRender(a4aElement, TEST_URL, true);
         expect(a4a.iframe.getAttribute('allow')).to.include("sync-xhr 'none';");
       });
-
-      it('should set feature policy for attribution-reporting when supported', async () => {
-        env.sandbox
-          .stub(privacySandboxUtils, 'isAttributionReportingAllowed')
-          .returns(true);
-        a4a.sandboxHTMLCreativeFrame = () => true;
-        a4a.onLayoutMeasure();
-        await a4a.layoutCallback();
-        verifyCachedContentIframeRender(a4aElement, TEST_URL, true);
-        expect(a4a.iframe.getAttribute('allow')).to.include("sync-xhr 'none';");
-        expect(a4a.iframe.getAttribute('allow')).to.include(
-          "attribution-reporting 'src';"
-        );
-      });
-
-      it('should not set feature policy for attribution-reporting when not supported', async () => {
-        env.sandbox
-          .stub(privacySandboxUtils, 'isAttributionReportingAllowed')
-          .returns(false);
-        a4a.sandboxHTMLCreativeFrame = () => true;
-        a4a.onLayoutMeasure();
-        await a4a.layoutCallback();
-        verifyCachedContentIframeRender(a4aElement, TEST_URL, true);
-        expect(a4a.iframe.getAttribute('allow')).to.include("sync-xhr 'none';");
-        expect(a4a.iframe.getAttribute('allow')).to.not.include(
-          "attribution-reporting 'src';"
-        );
-      });
     });
 
     describe('illegal render mode value', () => {
@@ -1038,30 +1009,6 @@ describes.realWin('amp-a4a', {amp: true}, (env) => {
         expect(fetchMock.called('ad')).to.be.true;
       });
 
-      it('should set feature policy for attribution-reporting when supported', async () => {
-        env.sandbox
-          .stub(privacySandboxUtils, 'isAttributionReportingAllowed')
-          .returns(true);
-        a4a.sandboxHTMLCreativeFrame = () => false;
-        a4a.onLayoutMeasure();
-        await a4a.layoutCallback();
-        verifyNameFrameRender(a4aElement, false /* shouldSandbox */);
-        expect(a4a.iframe.getAttribute('allow')).to.equal(
-          "sync-xhr 'none';attribution-reporting 'src';"
-        );
-      });
-
-      it('should not set feature policy for attribution-reporting when not supported', async () => {
-        env.sandbox
-          .stub(privacySandboxUtils, 'isAttributionReportingAllowed')
-          .returns(false);
-        a4a.sandboxHTMLCreativeFrame = () => false;
-        a4a.onLayoutMeasure();
-        await a4a.layoutCallback();
-        verifyNameFrameRender(a4aElement, false /* shouldSandbox */);
-        expect(a4a.iframe.getAttribute('allow')).to.equal("sync-xhr 'none';");
-      });
-
       ['', 'client_cache', 'safeframe', 'some_random_thing'].forEach(
         (headerVal) => {
           it(`should not attach a NameFrame when header is ${headerVal}`, async () => {
@@ -1171,38 +1118,6 @@ describes.realWin('amp-a4a', {amp: true}, (env) => {
         expect(fetchMock.called('ad')).to.be.true;
       });
 
-      it('should set feature policy for attribution-reporting when supported', async () => {
-        env.sandbox
-          .stub(privacySandboxUtils, 'isAttributionReportingAllowed')
-          .returns(true);
-        a4a.sandboxHTMLCreativeFrame = () => false;
-        a4a.onLayoutMeasure();
-        await a4a.layoutCallback();
-        verifySafeFrameRender(
-          a4aElement,
-          DEFAULT_SAFEFRAME_VERSION,
-          false /* shouldSandbox */
-        );
-        expect(a4a.iframe.getAttribute('allow')).to.equal(
-          "sync-xhr 'none';attribution-reporting 'src';"
-        );
-      });
-
-      it('should not set feature policy for attribution-reporting when not supported', async () => {
-        env.sandbox
-          .stub(privacySandboxUtils, 'isAttributionReportingAllowed')
-          .returns(false);
-        a4a.sandboxHTMLCreativeFrame = () => false;
-        a4a.onLayoutMeasure();
-        await a4a.layoutCallback();
-        verifySafeFrameRender(
-          a4aElement,
-          DEFAULT_SAFEFRAME_VERSION,
-          false /* shouldSandbox */
-        );
-        expect(a4a.iframe.getAttribute('allow')).to.equal("sync-xhr 'none';");
-      });
-
       ['', 'client_cache', 'nameframe', 'some_random_thing'].forEach(
         (headerVal) => {
           it(`should not attach a SafeFrame when header is ${headerVal}`, async () => {

extensions/amp-ad-exit/0.1/amp-ad-exit.js

@@ -14,10 +14,6 @@ import {Services} from '#service';
 
 import {getData} from '#utils/event-helper';
 import {dev, devAssert, user, userAssert} from '#utils/log';
-import {
-  AttributionReportingStatus,
-  isAttributionReportingAllowed,
-} from '#utils/privacy-sandbox-utils';
 
 import {TransportMode, assertConfig, assertVendor} from './config';
 import {makeClickDelaySpec} from './filters/click-delay';
@@ -93,8 +89,7 @@ export class AmpAdExit extends AMP.BaseElement {
     this.expectedOriginToVendor_ = {};
 
     /** @private @const {boolean} */
-    this.isAttributionReportingSupported_ =
-      this.detectAttributionReportingSupport();
+    this.isAttributionReportingSupported_ = false;
   }
 
   /**
@@ -191,10 +186,8 @@ export class AmpAdExit extends AMP.BaseElement {
   getUrlVariableRewriter_(args, event, target) {
     const substitutionFunctions = {
       'ATTRIBUTION_REPORTING_STATUS': () =>
-        getAttributionReportingStatus(
-          this.isAttributionReportingSupported_,
-          target
-        ),
+        // ARA removed
+        this.isAttributionReportingSupported_,
       'CLICK_X': () => event.clientX,
       'CLICK_Y': () => event.clientY,
     };
@@ -389,17 +382,7 @@ export class AmpAdExit extends AMP.BaseElement {
             .filter(Boolean),
           behaviors: target['behaviors'] || {},
         };
-        if (
-          this.isAttributionReportingSupported_ &&
-          target?.behaviors?.browserAdConversion
-        ) {
-          this.targets_[name]['windowFeatures'] =
-            this.getAttributionReportingValues_(
-              target?.behaviors?.browserAdConversion
-            );
-        } else {
-          this.targets_[name]['trackingUrls'] = target['trackingUrls'] || [];
-        }
+        this.targets_[name]['trackingUrls'] = target['trackingUrls'] || [];
 
         // Build a map of {vendor, origin} for 3p custom variables in the config
         for (const customVar in target['vars']) {
@@ -430,37 +413,6 @@ export class AmpAdExit extends AMP.BaseElement {
     this.init3pResponseListener_();
   }
 
-  /**
-   * Determine if `attribution-reporting` is supported by user-agent. Should only return
-   * true for Chrome 92+.
-   * @visibleForTesting
-   * @return {boolean}
-   */
-  detectAttributionReportingSupport() {
-    return isAttributionReportingAllowed(this.win.document);
-  }
-
-  /**
-   * Extracts the keys from the `browserAdConversion` data creates a
-   * string to be used as the `features` param for the `window.open()` call.
-   * @param {JsonObject} adConversionData
-   * @return {?string}
-   */
-  getAttributionReportingValues_(adConversionData) {
-    if (!adConversionData || !Object.keys(adConversionData)) {
-      return;
-    }
-
-    // `noopener` is probably redundant here but left as defense in depth.
-    // https://groups.google.com/a/chromium.org/g/blink-dev/c/FFX6VkvladY/m/QgaWHK6ZBAAJ
-    const parts = ['noopener'];
-    for (const key of Object.keys(adConversionData)) {
-      const encoded = encodeURIComponent(adConversionData[key]);
-      parts.push(`${key.toLowerCase()}=${encoded}`);
-    }
-    return parts.join(',');
-  }
-
   /**
    * Gets the resource ID of the amp-ad element containing this amp-ad-exit tag.
    * This is a pass-through for the version in service.js, solely because
@@ -580,26 +532,3 @@ export class AmpAdExit extends AMP.BaseElement {
 AMP.extension(TAG, '0.1', (AMP) => {
   AMP.registerElement(TAG, AmpAdExit);
 });
-
-/**
- * Resolves the ATTRIBUTION_REPORTING_STATUS macro to the appropriate value
- * based on the given config and browser support.
- * @param {boolean} isAttributionReportingSupported
- * @param {!NavigationTargetDef} target
- * @return {AttributionReportingStatus}
- * @visibleForTesting
- */
-export function getAttributionReportingStatus(
-  isAttributionReportingSupported,
-  target
-) {
-  if (
-    target?.behaviors?.browserAdConversion &&
-    isAttributionReportingSupported
-  ) {
-    return AttributionReportingStatus.ATTRIBUTION_DATA_PRESENT_AND_POLICY_ENABLED;
-  } else if (target?.behaviors?.browserAdConversion?.attributionsrc) {
-    return AttributionReportingStatus.ATTRIBUTION_DATA_PRESENT;
-  }
-  return AttributionReportingStatus.ATTRIBUTION_MACRO_PRESENT;
-}