accel/amdxdna: fix hwctx qos priroity mapping (1.8)#1353
Open
hlaccabu wants to merge 1 commit into
Open
Conversation
Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
hlaccabu
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the AIE4 hardware-context QoS priority handling by translating the UAPI QoS priority values (e.g., 0x100..0x280) into the device/firmware “priority band” values expected by the AIE4 management message.
Changes:
- Introduce an AIE4 “context priority band” enum for the HW context create message.
- Add a mapping helper to convert
AMDXDNA_QOS_*_PRIORITYvalues into AIE4 priority bands. - Update HW context creation to send the mapped priority band instead of the raw QoS value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| drivers/accel/amdxdna/aie4_msg_priv.h | Adds AIE4 context priority band enum used by management message fields. |
| drivers/accel/amdxdna/aie4_ctx.c | Converts user QoS priority values to AIE4 priority bands when creating HW contexts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.