Fix imported dma-buf mmap EINVAL error in qemu virtio path#1352
Open
dkotipal-xilinx wants to merge 1 commit into
Open
Fix imported dma-buf mmap EINVAL error in qemu virtio path#1352dkotipal-xilinx wants to merge 1 commit into
dkotipal-xilinx wants to merge 1 commit into
Conversation
|
|
||
| vma->vm_private_data = NULL; | ||
| vma->vm_ops = NULL; | ||
| vma->vm_pgoff = 0; |
Contributor
There was a problem hiding this comment.
when user calls mmap() it will provide the vm_pgoff.
Could you provide details on "imported dma-buf mmap was using DRM’s fake vm_pgoff instead of a buffer-relative offset" ?
drm used the offset passed from userspace to look up the gem object, and then calls the gem object mmap() function.
ret = dma_buf_mmap(abo->dma_buf, vma, 0); does the mmap() from offset 0.
thanks
Contributor
|
Hi @dkotipal-xilinx , recently, there is a change in xdna-driver and vxdna to disable mmap() for user pointer backed bo, could you try with latest kernel module in drivers/accel and latest vxdna? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mmap failure for imported BOs seen in qemu virtio (Failed to mmap dma buf -22).
Root cause: imported dma-buf mmap was using DRM’s fake vm_pgoff instead of a buffer-relative offset.
Fix: set vma->vm_pgoff = 0 before dma_buf_mmap() in the imported mmap path.
Scope: imported dma-buf mapping only; non-imported shmem path is unchanged.
Result: imported mmap succeeds, no -EINVAL in this flow.