media: c8sectpfe: Add of_node_put() when breaking out of loop

windhl · gregkh · commit fbf081ebe268 · 2022-12-31T13:14:18.000+01:00
[ Upstream commit 63ff05a ] In configure_channels(), we should call of_node_put() when breaking out of for_each_child_of_node() which will automatically increase and decrease the refcount. Fixes: c5f5d0f ("[media] c8sectpfe: STiH407/10 Linux DVB demux support") Signed-off-by: Liang He <windhl@126.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -940,6 +940,7 @@ static int configure_channels(struct c8sectpfei *fei)
 		if (ret) {
 			dev_err(fei->dev,
 				"configure_memdma_and_inputblock failed\n");
+			of_node_put(child);
 			goto err_unmap;
 		}
 		index++;

Original file line number	Diff line number	Diff line change
`@@ -940,6 +940,7 @@ static int configure_channels(struct c8sectpfei *fei)`
`940`	`940`	`if (ret) {`
`941`	`941`	`dev_err(fei->dev,`
`942`	`942`	`"configure_memdma_and_inputblock failed\n");`
	`943`	`+ of_node_put(child);`
`943`	`944`	`goto err_unmap;`
`944`	`945`	`}`
`945`	`946`	`index++;`