Skip to content

Commit a0d93aa

Browse files
Caixinchen1gregkh
authored andcommitted
rapidio: devices: fix missing put_device in mport_cdev_open
[ Upstream commit d5b6e6e ] When kfifo_alloc fails, the refcount of chdev->dev is left incremental. We should use put_device(&chdev->dev) to decrease the ref count of chdev->dev to avoid refcount leak. Link: https://lkml.kernel.org/r/20221203085721.13146-1-caixinchen1@huawei.com Fixes: e8de370 ("rapidio: add mport char device driver") Signed-off-by: Cai Xinchen <caixinchen1@huawei.com> Cc: Alexandre Bounine <alex.bou9@gmail.com> Cc: Dan Carpenter <error27@gmail.com> Cc: Jakob Koschel <jakobkoschel@gmail.com> Cc: John Hubbard <jhubbard@nvidia.com> Cc: Matt Porter <mporter@kernel.crashing.org> Cc: Wang Weiyang <wangweiyang2@huawei.com> Cc: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 7af9cb8 commit a0d93aa

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/rapidio/devices/rio_mport_cdev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,6 +1911,7 @@ static int mport_cdev_open(struct inode *inode, struct file *filp)
19111911
sizeof(struct rio_event) * MPORT_EVENT_DEPTH,
19121912
GFP_KERNEL);
19131913
if (ret < 0) {
1914+
put_device(&chdev->dev);
19141915
dev_err(&chdev->dev, DRV_NAME ": kfifo_alloc failed\n");
19151916
ret = -ENOMEM;
19161917
goto err_fifo;

0 commit comments

Comments
 (0)