Skip to content

Commit 96e5089

Browse files
gscuigregkh
authored andcommitted
net: stmmac: fix possible memory leak in stmmac_dvr_probe()
[ Upstream commit a137f3f ] The bitmap_free() should be called to free priv->af_xdp_zc_qps when create_singlethread_workqueue() fails, otherwise there will be a memory leak, so we add the err path error_wq_init to fix it. Fixes: bba2556 ("net: stmmac: Enable RX via AF_XDP zero-copy") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ecaf934 commit 96e5089

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7046,7 +7046,7 @@ int stmmac_dvr_probe(struct device *device,
70467046
priv->wq = create_singlethread_workqueue("stmmac_wq");
70477047
if (!priv->wq) {
70487048
dev_err(priv->device, "failed to create workqueue\n");
7049-
return -ENOMEM;
7049+
goto error_wq_init;
70507050
}
70517051

70527052
INIT_WORK(&priv->service_task, stmmac_service_task);
@@ -7273,6 +7273,7 @@ int stmmac_dvr_probe(struct device *device,
72737273
stmmac_napi_del(ndev);
72747274
error_hw_init:
72757275
destroy_workqueue(priv->wq);
7276+
error_wq_init:
72767277
bitmap_free(priv->af_xdp_zc_qps);
72777278

72787279
return ret;

0 commit comments

Comments
 (0)