Skip to content

Commit 4e501a3

Browse files
Xiu Jianfenggregkh
authored andcommitted
clk: samsung: Fix memory leak in _samsung_clk_register_pll()
[ Upstream commit 5174e5b ] If clk_register() fails, @pll->rate_table may have allocated memory by kmemdup(), so it needs to be freed, otherwise will cause memory leak issue, this patch fixes it. Fixes: 3ff6e0d ("clk: samsung: Add support to register rate_table for samsung plls") Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> Link: https://lore.kernel.org/r/20221123032015.63980-1-xiujianfeng@huawei.com Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 441c054 commit 4e501a3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/clk/samsung/clk-pll.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,6 +1385,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx,
13851385
if (ret) {
13861386
pr_err("%s: failed to register pll clock %s : %d\n",
13871387
__func__, pll_clk->name, ret);
1388+
kfree(pll->rate_table);
13881389
kfree(pll);
13891390
return;
13901391
}

0 commit comments

Comments
 (0)