fix(intel): remove checking on TEMP and VOLT checking for HWMON

BenjaminLimJL · sieumunt · commit 711823964a8b · 2022-10-06T18:59:11.000+08:00
Remove high level logic hardware channel checking on HWMON
TEMP and VOLT read.

Signed-off-by: Jit Loon Lim &lt;jit.loon.lim@intel.com&gt;
diff --git a/plat/intel/soc/common/socfpga_sip_svc.c b/plat/intel/soc/common/socfpga_sip_svc.c
@@ -469,10 +469,6 @@ static uint32_t intel_rsu_copy_dcmf_status(uint64_t dcmf_stat)
 /* Intel HWMON services */
 static uint32_t intel_hwmon_readtemp(uint32_t chan, uint32_t *retval)
 {
-	if (chan > TEMP_CHANNEL_MAX) {
-		return INTEL_SIP_SMC_STATUS_ERROR;
-	}
-
 	if (mailbox_hwmon_readtemp(chan, retval) < 0) {
 		return INTEL_SIP_SMC_STATUS_ERROR;
 	}
@@ -482,10 +478,6 @@ static uint32_t intel_hwmon_readtemp(uint32_t chan, uint32_t *retval)
 
 static uint32_t intel_hwmon_readvolt(uint32_t chan, uint32_t *retval)
 {
-	if (chan > VOLT_CHANNEL_MAX) {
-		return INTEL_SIP_SMC_STATUS_ERROR;
-	}
-
 	if (mailbox_hwmon_readvolt(chan, retval) < 0) {
 		return INTEL_SIP_SMC_STATUS_ERROR;
 	}

Original file line number	Diff line number	Diff line change
`@@ -469,10 +469,6 @@ static uint32_t intel_rsu_copy_dcmf_status(uint64_t dcmf_stat)`
`469`	`469`	`/* Intel HWMON services */`
`470`	`470`	`static uint32_t intel_hwmon_readtemp(uint32_t chan, uint32_t *retval)`
`471`	`471`	`{`
`472`		`- if (chan > TEMP_CHANNEL_MAX) {`
`473`		`- return INTEL_SIP_SMC_STATUS_ERROR;`
`474`		`- }`
`475`		`-`
`476`	`472`	`if (mailbox_hwmon_readtemp(chan, retval) < 0) {`
`477`	`473`	`return INTEL_SIP_SMC_STATUS_ERROR;`
`478`	`474`	`}`
`@@ -482,10 +478,6 @@ static uint32_t intel_hwmon_readtemp(uint32_t chan, uint32_t *retval)`
`482`	`478`
`483`	`479`	`static uint32_t intel_hwmon_readvolt(uint32_t chan, uint32_t *retval)`
`484`	`480`	`{`
`485`		`- if (chan > VOLT_CHANNEL_MAX) {`
`486`		`- return INTEL_SIP_SMC_STATUS_ERROR;`
`487`		`- }`
`488`		`-`
`489`	`481`	`if (mailbox_hwmon_readvolt(chan, retval) < 0) {`
`490`	`482`	`return INTEL_SIP_SMC_STATUS_ERROR;`
`491`	`483`	`}`