Merge pull request #44 from altasoft/bugfix/TimeOnlyTimezone

Update TimeOnly ToXmlString to include time zone offset

Author: GregoryNikolaishvili

Directory.Packages.props

@@ -14,7 +14,7 @@
 
 	<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.*" />
 	<PackageVersion Include="Verify.SourceGenerators" Version="2.5.*" />
-	<PackageVersion Include="Verify.Xunit" Version="31.9.3" />
+	<PackageVersion Include="Verify.Xunit" Version="31.12.5" />
 	<PackageVersion Include="xunit" Version="2.9.3" />
 	<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
 	<PackageVersion Include="coverlet.collector" Version="6.0.4" />

src/AltaSoft.DomainPrimitives/ToXmlStringExt.cs

@@ -31,12 +31,27 @@ public static class ToXmlStringExt
     public static string ToXmlString(this DateOnly value) => value.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture);
 
     /// <summary>
-    /// Converts a <see cref="TimeOnly" /> value to its XML string representation in the format "HH:mm:ss".
+    /// Converts a <see cref="TimeOnly" /> value to its XML string representation in the format "HH:mm:sszzz",
+    /// where the time zone offset reflects the current local offset from UTC.
     /// </summary>
     /// <param name="value">The TimeOnly value to convert.</param>
     /// <returns>The XML string representation of the TimeOnly value.</returns>
+
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static string ToXmlString(this TimeOnly value) => value.ToString("HH:mm:ss", CultureInfo.InvariantCulture);
+    public static string ToXmlString(this TimeOnly value)
+    {
+        // We avoid constructing a local DateTime for an arbitrary date to prevent
+        // possible exceptions on DST transition days (invalid or ambiguous local times).
+        var timePart = value.ToString("HH:mm:ss", CultureInfo.InvariantCulture);
+
+        // Derive the current local offset from UTC in a DST-safe way using the current instant.
+        var offset = TimeZoneInfo.Local.GetUtcOffset(DateTime.UtcNow);
+        var offsetSign = offset < TimeSpan.Zero ? "-" : "+";
+        var absoluteOffset = offset.Duration();
+        var offsetPart = absoluteOffset.ToString(@"hh\:mm", CultureInfo.InvariantCulture);
+
+        return $"{timePart}{offsetSign}{offsetPart}";
+    }
 
     /// <summary>
     /// Converts a <see cref="DateTimeOffset" /> value to its XML string representation

tests/AltaSoft.DomainPrimitives.XmlDataTypes.Tests/ToXmlStringExtTests.cs

@@ -24,7 +24,15 @@ public void TimeOnly_ToXmlString_ReturnsExpectedFormat()
     {
         var t = new TimeOnly(13, 45, 30);
         var xml = t.ToXmlString();
-        Assert.Equal("13:45:30", xml);
+
+        // Validate the overall shape: time followed by a timezone offset
+        Assert.Matches(@"^13:45:30[+-]\d{2}:\d{2}$", xml);
+
+        // Validate the offset suffix matches the actual current local offset
+        var offset = TimeZoneInfo.Local.GetUtcOffset(DateTime.UtcNow);
+        var offsetSign = offset < TimeSpan.Zero ? "-" : "+";
+        var expectedOffsetSuffix = $"{offsetSign}{offset.Duration():hh\\:mm}";
+        Assert.EndsWith(expectedOffsetSuffix, xml);
     }
 
     [Fact]