Skip to content

Assuming arguments are strings leads to crash #211

@joelanman

Description

@joelanman

For example if a prototype kit user doesn't have an API key, they get this error

Cannot read properties of undefined (reading 'substring')

Because lines like this assume string:

https://github.com/alphagov/notifications-node-client/blob/main/client/api_client.js#L20

A more helpful error would be something like 'API key is required'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions