chore(x/vaas/consumer): remove fabricated staking.Params response fields#45
Merged
Merged
Conversation
giunatale
requested review from
clockworkgr,
giuliostramondo,
julienrbrt and
tbruyelle
as code owners
tbruyelle
approved these changes
May 17, 2026
Contributor
tbruyelle
left a comment
tbruyelle
left a comment
There was a problem hiding this comment.
I'm not sure either why these values were added in the first place, but it looks legitimate to remove them.
Since the e2e tests are still passing, this tends to prove that these values aren't really needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consumer module registers a stub
cosmos.staking.v1beta1.Query/Paramshandler so IBC relayers can readUnbondingTimewhen deriving thetrusting_periodof a Tendermint light client targeting the consumer chain.The stub used to fill in the rest of the response with hardcoded values, but they are fictional and misleading. On top of that, they are essentially not needed. Removing these hard-coded values to clean-up the code. Added also a test for regression, although it could be arguably "too much".
A second-degree consideration here: why are we providing this stub? I guess because
ts-relayerdoesn't have a "vaas mode" to read the required values directly from querying the consumer module's params? Theinterchain-securityimplementation doesn't provide this stub.