Updated DBs and analizer (#1064)

* Updated DBs and analizer

* fix

* fix

* database Lc pK0s vs mult

* data/data_run3/database_ml_parameters_D0pp_mult_CorrBkg.yml

* fix signal count

* fix

* fix

* add corr bkg

---------

Co-authored-by: Luigi Dello Stritto <ldellost@alicecerno2.cern.ch>

Author: DelloStritto

machine_learning_hep/analysis/analyzer_jets.py

@@ -401,7 +401,7 @@ def _roofit_mass(self, level, hist, ipt, pdfnames, param_names, fitcfg, roows=No
         if level == "data":
             mean_sgn = ws.var(self.p_param_names["gauss_mean"])
             sigma_sgn = ws.var(self.p_param_names["gauss_sigma"])
-            (sig, sig_err, bkg, bkg_err, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
+            (sig, sig_err, _, _, bkg, bkg_err, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
                 ws, res, pdfnames, param_names, mean_sgn, sigma_sgn
             )
             add_text_info_perf(textInfoLeft, sig, sig_err, bkg, bkg_err, s_over_b, s_over_b_err, signif, signif_err)

machine_learning_hep/analysis/analyzerdhadrons.py

@@ -183,7 +183,7 @@ def _roofit_mass(self, level, hist, ipt, pdfnames, param_names, fitcfg, roows=No
         if level == "data":
             mean_sgn = ws.var(self.p_param_names["gauss_mean"])
             sigma_sgn = ws.var(self.p_param_names["gauss_sigma"])
-            (sig, sig_err, bkg, bkg_err, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
+            (sig, sig_err, _, _, bkg, bkg_err, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
                 ws, res, pdfnames, param_names, mean_sgn, sigma_sgn
             )
 
@@ -304,7 +304,7 @@ def fit(self):
                             self.lpt_finbinmax[ipt],
                             lpt_probcutfin[ipt],
                         )
-                    h_invmass = rfile.Get("hmass" + suffix)
+                    h_invmass = rfile.Get("hmass_" + suffix)
                     # Rebin
                     h_invmass.Rebin(self.p_rebin[ipt])
                     if h_invmass.GetEntries() < 100:  # TODO: reconsider criterion
@@ -341,6 +341,7 @@ def fit(self):
                                 roows.var(fixpar).setConstant(True)
                         if h_invmass.GetEntries() == 0:
                             continue
+
                         roo_res, roo_ws = self._roofit_mass(
                             level,
                             h_invmass,
@@ -371,7 +372,7 @@ def fit(self):
                         if level == "data":
                             mean_sgn = roo_ws.var(self.p_param_names["gauss_mean"])
                             sigma_sgn = roo_ws.var(self.p_param_names["gauss_sigma"])
-                            (sig, sig_err, _, _, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
+                            (sig, sig_err, _, _, _, _, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
                                 roo_ws, roo_res, self.p_pdfnames, self.p_param_names, mean_sgn, sigma_sgn
                             )
 
@@ -418,7 +419,7 @@ def efficiency(self):
         print(self.n_fileff)
         lfileeff = TFile.Open(self.n_fileff)
         lfileeff.ls()
-        fileouteff = TFile.Open(f"{self.d_resultsallpmc}/{self.efficiency_filename}{self.case}{self.typean}.root", "recreate")
+        fileouteff = TFile.Open(f"{self.d_resultsallpmc}/efficiencies{self.case}{self.typean}.root", "recreate")
         cEff = TCanvas("cEff", "The Fit Canvas")
         cEff.SetCanvasSize(1900, 1500)
         cEff.SetWindowSize(500, 500)
@@ -494,7 +495,7 @@ def makenormyields(self):  # pylint: disable=import-outside-toplevel, too-many-b
         if not os.path.exists(yield_filename):
             self.logger.fatal("Yield file %s could not be found", yield_filename)
 
-        fileouteff = f"{self.d_resultsallpmc}/{self.efficiency_filename}{self.case}{self.typean}.root"
+        fileouteff = f"{self.d_resultsallpmc}/efficiencies{self.case}{self.typean}.root"
         if not os.path.exists(fileouteff):
             self.logger.fatal("Efficiency file %s could not be found", fileouteff)
 
@@ -506,12 +507,13 @@ def makenormyields(self):  # pylint: disable=import-outside-toplevel, too-many-b
 
         histonorm = TH1F("histonorm", "histonorm", 1, 0, 1)
 
+        filemass = TFile.Open(self.n_filemass)
+        hevents = filemass.Get("all_events")
+        hselevents = filemass.Get("sel_events")
+
         if self.p_nevents is not None:
             selnorm = self.p_nevents
         else:
-            filemass = TFile.Open(self.n_filemass)
-            hevents = filemass.Get("all_events")
-            hselevents = filemass.Get("sel_events")
             norm, selnorm = self.calculate_norm(self.logger, hevents, hselevents)
             histonorm.SetBinContent(1, selnorm)
             self.logger.warning("Number of events %d", norm)
@@ -554,9 +556,7 @@ def makenormyields(self):  # pylint: disable=import-outside-toplevel, too-many-b
         f_fileoutcross = TFile.Open(fileoutcross)
         if f_fileoutcross:
             hcross = f_fileoutcross.Get("hptspectrum")
-            hcrossbr = f_fileoutcross.Get("hptspectrum_wo_br")
             fileoutcrosstot.cd()
             hcross.Write()
-            hcrossbr.Write()
         histonorm.Write()
         fileoutcrosstot.Close()

machine_learning_hep/analysis/analyzerdhadrons_mult.py

@@ -50,7 +50,7 @@
 )
 from machine_learning_hep.hf_pt_spectrum import hf_pt_spectrum
 from machine_learning_hep.logger import get_logger
-from machine_learning_hep.utils.hist import get_dim, project_hist
+from machine_learning_hep.utils.hist import get_dim
 
 
 # pylint: disable=too-few-public-methods, too-many-instance-attributes, too-many-statements, fixme
@@ -211,7 +211,7 @@ def _roofit_mass(self, level, hist, ipt, pdfnames, param_names, fitcfg, roows=No
         if level == "data":
             mean_sgn = ws.var(self.p_param_names["gauss_mean"])
             sigma_sgn = ws.var(self.p_param_names["gauss_sigma"])
-            (sig, sig_err, bkg, bkg_err, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
+            (sig, sig_err, _, _, bkg, bkg_err, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
                 ws, res, pdfnames, param_names, mean_sgn, sigma_sgn
             )
 
@@ -320,7 +320,7 @@ def fit(self):
                     for ipt in range(len(self.lpt_finbinmin)):
                         lpt_probcutfin[ipt] = self.lpt_probcutfin_tmp[self.bin_matching[ipt]]
                         self.logger.debug("fitting %s - %i - %i", level, ipt, ibin2)
-                        roows = self.roows.get(ipt)
+                        roows = self.roows.get((ibin2, ipt))
                         if self.mltype == "MultiClassification":
                             suffix = "%s%d_%d_%.2f%.2f%s_%.2f_%.2f" % (
                                 self.v_var_binning,
@@ -342,9 +342,11 @@ def fit(self):
                                 self.lvar2_binmin[ibin2],
                                 self.lvar2_binmax[ibin2],
                             )
-                        h_invmass = rfile.Get("hmass" + suffix)
+                        h_invmass = rfile.Get("hmass_" + suffix)
                         # Rebin
-                        h_invmass.Rebin(self.p_rebin[ipt])
+                        # rebin = self.p_rebin[ibin2][ipt]
+                        rebin = self.p_rebin[ipt]
+                        h_invmass.Rebin(rebin)
                         if h_invmass.GetEntries() < 100:  # TODO: reconsider criterion
                             self.logger.error(
                                 "Not enough entries to fit for %s, pt bin %d, mult bin %d", level, ipt, ibin2
@@ -378,12 +380,14 @@ def fit(self):
                                 break
                             self.logger.debug("Using fit config for %i: %s", ipt, fitcfg)
                             if datasel := fitcfg.get("datasel"):
-                                h = rfile.Get(f"h_mass-pthf_{datasel}")
-                                h_invmass = project_hist(h, [0], {1: (ipt + 1, ipt + 1)})
+                                h_invmass = rfile.Get(f"hmass_{datasel}_{suffix}")
 
                             for fixpar in fitcfg.get("fix_params", []):
                                 if roows.var(fixpar):
                                     roows.var(fixpar).setConstant(True)
+                            for par in fitcfg.get("free_params", []):
+                                if roows.var(par):
+                                    roows.var(par).setConstant(False)
                             if h_invmass.GetEntries() == 0:
                                 continue
 
@@ -405,8 +409,8 @@ def fit(self):
                             )
                             # if level == 'mc':
                             #     roo_ws.Print()
-                            self.roo_ws[level][ipt] = roo_ws
-                            self.roows[ipt] = roo_ws
+                            self.roows[(ibin2, ipt)] = roo_ws.Clone()
+                            self.roo_ws[(level, ibin2, ipt)] = roo_ws.Clone()
                             if roo_res.status() == 0:
                                 if level in ("data", "mc_sig"):
                                     self.fit_mean[level][ipt] = roo_ws.var(self.p_param_names["gauss_mean"]).getValV()
@@ -425,7 +429,7 @@ def fit(self):
                             if level == "data":
                                 mean_sgn = roo_ws.var(self.p_param_names["gauss_mean"])
                                 sigma_sgn = roo_ws.var(self.p_param_names["gauss_sigma"])
-                                (sig, sig_err, _, _, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
+                                (sig, sig_err, _, _, _, _, signif, signif_err, s_over_b, s_over_b_err) = calc_signif(
                                     roo_ws, roo_res, self.p_pdfnames, self.p_param_names, mean_sgn, sigma_sgn
                                 )
 
@@ -573,7 +577,7 @@ def efficiency(self):
                 h_sel_fd_sl.SetName("signal_loss_fd_mult%d" % imult)
                 h_sel_fd_sl.Write()
 
-                legslFD.AddEntry(h_sel_fd_sl, legeffstring, "LEP")
+                legslFD.AddEntry(h_sel_fd_sl, legeffFDstring, "LEP")
                 h_sel_fd_sl.GetXaxis().SetTitle("#it{p}_{T} (GeV/#it{c})")
                 h_sel_fd_sl.GetYaxis().SetTitle("Signal loss (feeddown) %s" % (self.p_latexnhadron))
                 h_sel_fd_sl.SetMinimum(0.7)