fix: Fix SIGABRT when adding nullable column to multi-segment collection#416
Open
chinaux wants to merge 1 commit into
Open
fix: Fix SIGABRT when adding nullable column to multi-segment collection#416chinaux wants to merge 1 commit into
chinaux wants to merge 1 commit into
Conversation
…lection (alibaba#415) When add_column is called on a multi-segment collection with a nullable field and no expression, segment.cc previously sliced an Arrow ChunkedArray with an offset that exceeded the array length, triggering SIGABRT in Arrow's chunked_array.cc:170 assertion. Fix the slicing logic in segment.cc to materialize null values per segment. Add comprehensive tests in collection_test.cc and segment_test.cc covering multi-segment add_column scenarios (nullable/non-nullable, with/without expression, with/without unflushed data, drop+re-add).
zhourrr
force-pushed
the
fix/fix_add_column_crash
branch
from
579a66b to
5a34efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix (#415)
When add_column is called on a multi-segment collection with a nullable field and no expression, segment.cc previously sliced an Arrow ChunkedArray with an offset that exceeded the array length, triggering SIGABRT in Arrow's chunked_array.cc:170 assertion.