Fix missing modes in modelist#5977
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
puneetdixit200
force-pushed
the
fix/5926-modelist-missing-modes
branch
from
a4d0529 to
a157102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #5926
Description of changes:
Adds the existing
applescript,csp,plain_text, andredshiftmodes toext/modelist, so they are exposed throughmodesandmodesByName. Also adds a focused regression test for these mode entries.Tests:
node src/ext/modelist_test.js./node_modules/.bin/mocha src/ext/modelist_test.js --exit --color./node_modules/.bin/eslint src/ext/modelist.js src/ext/modelist_test.jsgit diff --checkBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references:Open kitchen-sink @ a4d05296b0e7c551b93299397e77438536516ff5
Open kitchen-sink @ a1571027f8c65457693a82eb9c3edb2cb2c1c96e