Skip to content

Replace ace workers with ace-legacy-linters#5938

Open
mkslanc wants to merge 4 commits into
ajaxorg:masterfrom
mkslanc:replace-workers
Open

Replace ace workers with ace-legacy-linters#5938
mkslanc wants to merge 4 commits into
ajaxorg:masterfrom
mkslanc:replace-workers

Conversation

@mkslanc
Copy link
Copy Markdown
Contributor

@mkslanc mkslanc commented Apr 8, 2026

Issue #, if available: #4946 #5256 #3901 #3747 #3479 #5854

Description of changes:

  • Drop-in replacements for legacy workers. Should handle most of worker-related issues for those, who don't want to use separate language client or need simple diagnostics.
  • Add diagnostics support additionally for less and scss

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Open kitchen-sink @ 76cdf283f24ff68b419ac21588bf9d2cad1ccfd2

Open kitchen-sink @ 622a87103dd645053583d95c54585c178b04f613

Open kitchen-sink @ af6e826645eefd2593bf9f51842fbdef9d4f1cb4

Open kitchen-sink @ 62e948f298b8d9490d3c8e6dd2f3864375b960c2

@mkslanc mkslanc marked this pull request as ready for review April 10, 2026 15:30
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.72%. Comparing base (a467a6c) to head (62e948f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/mode/less.js 88.23% 2 Missing ⚠️
src/mode/scss.js 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5938    +/-   ##
========================================
  Coverage   93.72%   93.72%            
========================================
  Files         634      640     +6     
  Lines      137322   137772   +450     
  Branches    14469    14475     +6     
========================================
+ Hits       128708   129131   +423     
- Misses       8614     8641    +27     
Flag Coverage Δ
unittests 93.72% <87.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants