Skip to content

Commit 8b5010b

Browse files
committed
refact isVideoOff method and
add "seleniumVideoDefaultOff" System property for control whether video recording feature default disabled or not Signed-off-by: qxo <qxodream@gmail.com>
1 parent 8d72f4e commit 8b5010b

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

src/main/java/com/aimmac23/hub/proxy/VideoProxy.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
package com.aimmac23.hub.proxy;
22

3+
import java.util.Map;
34
import java.util.logging.Level;
45
import java.util.logging.Logger;
56

67
import javax.servlet.http.HttpServletRequest;
78
import javax.servlet.http.HttpServletResponse;
89

10+
import org.apache.commons.lang3.StringUtils;
911
import org.apache.http.HttpHost;
1012
import org.apache.http.HttpResponse;
1113
import org.apache.http.HttpStatus;
@@ -98,10 +100,15 @@ public void beforeSession(TestSession arg0) {
98100
}
99101

100102
private boolean isVideoOff(TestSession testSession) {
101-
final Object videoDisabled = testSession.getRequestedCapabilities().get("_videoOff");
102-
boolean disabled = videoDisabled == null ? false :
103-
videoDisabled instanceof Boolean && Boolean.TRUE.equals(videoDisabled)
104-
|| "true".equals(videoDisabled.toString());
103+
Map<String, Object> requestedCapabilities = testSession.getRequestedCapabilities();
104+
final Object videoDisabled = requestedCapabilities.get("_videoOff");
105+
boolean disabled ;
106+
if( videoDisabled == null || StringUtils.isBlank(videoDisabled.toString())){
107+
disabled = Boolean.getBoolean("seleniumVideoDefaultOff");
108+
}else{
109+
disabled = videoDisabled instanceof Boolean ? Boolean.TRUE.equals(videoDisabled)
110+
: "true".equals(videoDisabled.toString());
111+
}
105112
return disabled;
106113
}
107114

0 commit comments

Comments
 (0)