Merge pull request #106 from ahwm/copilot/sub-pr-87

Fix code review feedback: API typo, null safety, duplicate property, docs

Author: ahwm

src/GodaddyWrapper/Client.Agreements.cs

@@ -22,7 +22,7 @@ public async Task<List<LegalAgreementResponse>> RetrieveAgreements(AgreementRetr
                 httpClient.DefaultRequestHeaders.Add("X-Private-Label-Id", XPrivateLabelId);
             if (XMarketId != null)
                 httpClient.DefaultRequestHeaders.Add("X-Market-Id", XMarketId);
-            var response = await httpClient.GetAsync($"{V1_BASE}aggreements{QueryStringBuilder.RequestObjectToQueryString(request)}");
+            var response = await httpClient.GetAsync($"{V1_BASE}agreements{QueryStringBuilder.RequestObjectToQueryString(request)}");
             await CheckResponseMessageIsValid(response);
             return await response.Content.ReadAsAsync<List<LegalAgreementResponse>>(JsonSettings);
         }

src/GodaddyWrapper/Client.Domain.cs

@@ -9,7 +9,6 @@ namespace GodaddyWrapper
 {
     public partial class GoDaddyClient
     {
-        private const string V1_BASE = "v1/";
 
         /// <summary>
         /// Add the specified DNS Records to the specified Domain

src/GodaddyWrapper/Client.cs

@@ -22,6 +22,9 @@ namespace GodaddyWrapper
 {
     public partial class GoDaddyClient
     {
+        private const string V1_BASE = "v1/";
+        private const string V2_BASE = "v2/";
+
         private readonly HttpClient httpClient;
         private readonly static JsonSerializerOptions JsonSettings = JsonContext.Default.Options;
 

src/GodaddyWrapper/Helper/QueryStringBuilder.cs

@@ -69,7 +69,8 @@ public static string DictionaryToQueryString(Dictionary<string, string> paramete
             var query = new StringBuilder("?");
             foreach (var kvp in parameters)
             {
-                query.Append($"{kvp.Key}={Uri.EscapeDataString(kvp.Value)}&");
+                if (kvp.Value != null)
+                    query.Append($"{kvp.Key}={Uri.EscapeDataString(kvp.Value)}&");
             }
             return query.ToString().TrimEnd('&');
         }

src/GodaddyWrapper/Requests/DomainUpdateV2.cs

@@ -32,10 +32,5 @@ public class DomainUpdateV2
         /// Whether or not privacy protection is enabled
         /// </summary>
         public bool? PrivacyEnabled { get; set; }
-
-        /// <summary>
-        /// Whether or not the domain is set to auto-renew
-        /// </summary>
-        public bool? AutoRenewEnabled { get; set; }
     }
 }

src/GodaddyWrapper/Services.cs

@@ -8,7 +8,7 @@ namespace GodaddyWrapper
     public static class ServicesExtension
     {
         /// <summary>
-        /// Add GoDaddy API client with v1 endpoints
+        /// Add GoDaddy API client
         /// </summary>
         /// <param name="services"></param>
         /// <param name="accessKey"></param>