Files cannot be attached from the Library in the add attachements Dialog

[rparsimony]

Hello,

We are running into an issue with this where, attaching a file to any other documents from the Library. The file appears there, for about 2 seconds and then disappears.

Could the after_insert hook be misbehaving or some such? When does it trigger?

Another minor issue, but the file_doc.update hook seems to be misbehaving and creating/leaving duplicates behind. Changing the file_doc.update to utilize the file_doc.save() method seems to have solve that issue. If this is incorrect, please let me know.

• Cheers

[rparsimony]

The version control doesn't seem to be working as intended as well. I was informed that there used to be multiple versions of the file present in the list and you could revert them.

[rparsimony]

@fproldan
I tried the changes that were present in the Pull request and they worked to allow attaching from the library, but now deleting/removing the attachments by clicking the little X next to the attachments doesn't work.

[rparsimony]

Took another look at this and it seems it was only happening when a file had a single file_association. Took a bit to find out what was happening but and I'm still not sure but this seems to be the main crux of the issue here:

if row.link_doctype == self.attached_to_doctype and row.link_name == self.attached_to_name:  # type: ignore
    # calculate the index of the next file association in the list, looping to the start if already at the end
    next_idx = (idx + 1) % len(self.file_association)
    next_file_association = self.file_association[next_idx]
    self.attached_to_doctype = next_file_association.link_doctype
    self.attached_to_name = next_file_association.link_name

The code is fine, but somewhere along the way Frappe added another task that runs on file detachment which makes sure that if a file is attached to a document somewhere with the file.attached_to_doctype and the file.attached_to_name, that it will stay attached and the file_association will be regenerated.

Changing it to this seems to work so far:

if row.link_doctype == self.attached_to_doctype and row.link_name == self.attached_to_name:  # type: ignore
  if len(self.file_association) <= 1:
    self.attached_to_doctype = None
    self.attached_to_name    = None
    self.attached_to_field   = None
  else:
    # calculate the index of the next file association in the list, looping to the start if already at the end
    next_idx = (idx + 1) % len(self.file_association)
    next_file_association = self.file_association[next_idx]
    self.attached_to_doctype = next_file_association.link_doctype
    self.attached_to_name = next_file_association.link_name

Not sure if this is just from the many alterations that are in our codebase but that was the issue we were having and the prototype/experimental fix. Will report back if it doesn't work.

[rparsimony]

Found another slight issue with the fix that is currently in the pull request. Sometimes, when uploading a file, the after_insert would insert a second instance of the file association.

This fixes that up quite nicely:

existing_file = frappe.get_doc("File", associated_doc)
if not any(d.get("link_name") == new_association.get("link_name") for d in existing_file.get("file_association")):
        existing_file.append("file_association", new_association)
        existing_file.save()

[IshwaryaM1030]

@agritheory This issue is resolved in #90